Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First part of article is missing from Reader View: https://www.bloomberg.com/graphics/2023-generative-ai-bias/ #955

Open
klowermoz opened this issue Feb 19, 2025 · 1 comment

Comments

@klowermoz
Copy link

This is an interactive article from Bloomberg: https://www.bloomberg.com/graphics/2023-generative-ai-bias/

The first part of the article has graphics and text that change as you scroll.

Reader View only renders what is after this first part.

I would expect it to render the whole article.

Where Reader View starts
Image

The start of the source (a bit hard to capture in still images, alas).
Image

Image

@gijsk
Copy link
Contributor

gijsk commented Feb 19, 2025

Looks like cleanConditionally (

this._cleanConditionally(articleContent, "div");
) is removing this content after it correctly gets selected as part of the main body of the article, at least with 0.5.0 (haven't retested main which we haven't merged into Firefox in a while).

The bits inside "A color photograph of an imate" get removed because in the markup, each image (which transitions as you scroll) is recorded as an image, and we remove containers with loads of images and no text. Readability isn't clever enough to realize this is some kind of animation, purely from the markup.

It looks like the main large bit of text gets removed because it's in a container with an ID that contains "scroll" which is in the negatively correlated list at

/-ad-|hidden|^hid$| hid$| hid |^hid |banner|combx|comment|com-|contact|footer|gdpr|masthead|media|meta|outbrain|promo|related|scroll|share|shoutbox|sidebar|skyscraper|sponsor|shopping|tags|widget/i,
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants