Skip to content
This repository was archived by the owner on Dec 16, 2022. It is now read-only.

Consider mirroring OneCRLTools code in canary repo #59

Closed
mwobensmith opened this issue May 31, 2017 · 2 comments
Closed

Consider mirroring OneCRLTools code in canary repo #59

mwobensmith opened this issue May 31, 2017 · 2 comments

Comments

@mwobensmith
Copy link
Contributor

Based on previous issue, where we seem to have a regression in a library we depend on, perhaps we should consider storing our own cache of the OneCRLTools code. The canary can't run correctly without it.

We could also consider other scenarios, like running the canary with warnings if this code is not working.

@mwobensmith mwobensmith changed the title Consider caching OneCRLTools code Consider mirroring OneCRLTools code in canary repo May 31, 2017
@cr
Copy link
Contributor

cr commented May 31, 2017

I don't think it's feasible for the reasons discussed in #58.

The onecrl binary unfortunately does not report errors. This issue has been reported upstream in https://github.com/mozmark/OneCRL-Tools/issues/3. There already is a sanity check in https://github.com/mozilla/tls-canary/blob/master/one_crl_downloader.py#L71 for the onecrl output, and it makes tls_canary log a critical error and exit if onecrl yields an empty result. This is far from ideal, but so far it's the only way I found to detect onecrl error conditions.

@cr
Copy link
Contributor

cr commented May 31, 2017

Let me add that the current problem is not caused by a onecrl runtime issue, but by an error in the onecrl package during the go get / install phase.

@cr cr mentioned this issue Jun 2, 2017
@cr cr added the wontfix label Jun 2, 2017
@cr cr closed this as completed Jun 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants