Create and use Wrapper classes for widgets #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are sliders that wrap either ipywidgets or matplotlib sliders This should make it easier to expose the raw sliders created by mpl-interactions to the users.
Default to using mpl's ScalarFormatter
This was referenced May 30, 2021
ianhi
commented
May 30, 2021
| self.params[k] = control.index | ||
| try: | ||
| control.observe(partial(self._slider_updated, key=k), names="index") | ||
| except AttributeError: |
There was a problem hiding this comment.
make this a more nuanced attribute error wher eyou look for a specific message - if thts possible
ianhi
commented
Jun 10, 2021
Comment on lines
160
to
162
| """ | ||
| gotta also give the indices in order to support hyperslicer without horrifying contortions | ||
| """ |
There was a problem hiding this comment.
remove. this is no longer true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will eventually close: #183
Not really there yet (may yet restructure) but nice to open early
TODO: