Add --max-body

danihodovic · danihodovic · commit c5a46a794488 · 2019-12-10T19:00:21.000+01:00
Fixes danihodovic#50
diff --git a/README.md b/README.md
@@ -38,3 +38,8 @@ X-Powered-By: Express
     "html": "\n    <!doctype html>\n    ..."
 }
 ```
+
+#### Configuration
+
+A list of available configuration options can be found in
+[./lib/parse_args.js](./lib/parse_args.js).
diff --git a/lib/parse_args.js b/lib/parse_args.js
@@ -38,4 +38,10 @@ module.exports.argv = yargs
     type: 'string',
     choices: ['strict', 'soft', 'skip']
   })
+  .option('max-body', {
+    demandOption: false,
+    default: '1mb',
+    describe: 'Max size of the http body',
+    type: 'string'
+  })
   .argv;
diff --git a/lib/server.js b/lib/server.js
@@ -19,7 +19,10 @@ module.exports.create = (argv) => {
 
   const app = express();
   app.use(loggingMiddleware);
-  app.use(bodyParser.text({ type: () => true }));
+  app.use(bodyParser.text({
+    type: () => true,
+    limit: argv.maxBody
+  }));
   app.post(renderEndpoint, (req, res) => {
     let html, errors;
 
diff --git a/test/test.js b/test/test.js
@@ -65,6 +65,26 @@ describe('server', function () {
   });
 });
 
+describe('with --max-body', function () {
+  let server;
+  let url;
+
+  before(async () => {
+    server = await create({ maxBody: '10' }).listen();
+    url = `http://localhost:${server.address().port}`;
+  });
+
+  after(async () => {
+    await server.close();
+  });
+
+  it('returns 413 for payloads larger than --max-body', async () => {
+    const data = 'o'.repeat(10);
+    const res = await makeReq(url, { data: `<mj-text>${data}</mj-text>` });
+    expect(res.status).to.eql(413);
+  });
+});
+
 const makeReq = (url, { method = 'POST', path = '/v1/render', data = '' } = {}) => {
   return axios({
     method: 'POST',

Original file line number	Diff line number	Diff line change
`@@ -38,3 +38,8 @@ X-Powered-By: Express`
`38`	`38`	`"html": "\n <!doctype html>\n ..."`
`39`	`39`	`}`
`40`	`40`	```
	`41`	`+`
	`42`	`+#### Configuration`
	`43`	`+`
	`44`	`+A list of available configuration options can be found in`
	`45`	`+[./lib/parse_args.js](./lib/parse_args.js).`