Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract carehomes_parameters parameters to controls #275

Open
RaphaelS1 opened this issue Apr 9, 2021 · 1 comment
Open

Abstract carehomes_parameters parameters to controls #275

RaphaelS1 opened this issue Apr 9, 2021 · 1 comment

Comments

@RaphaelS1
Copy link
Contributor

As discussed, we now have many parameters that take same default values and can be grouped together, cleaner abstraction into controls would allow separated assertions on parameters, re-use of same defaults, more manageable carehomes_parameters function.

e.g. Instead of parameters:

vaccine_progression_rate = NULL
vaccine_schedule = NULL
vaccine_index_dose2 = NULL
vaccine_catchup_fraction = 1

We have a function:

vaccine_control <- function(progression_rate = NULL, vaccine_schedule = NULL,
vaccine_index_dose_2 = NULL, vaccine_catchup_fraction = 1) {
 ...
}

Put all the vaccine parameter checks in there (the ones that don't require other params) and then in carehomes_parameters we make these one parameter: vaccine_parameters <- vaccine_control()

@RaphaelS1
Copy link
Contributor Author

Once #278 and #277 are closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant