fix: don't ignore at_edge for floating windows #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay. Been crazy at my day job. I am pretty sure that ignoring I would be open to adding support for |
That would be even better. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #217
Before this PR, we never invoke the user's custom
at_edgebehavior for floating windows (see minimal repro). Instead, we return early.This PR ensures that, for floating windows, we call
handle_at_edge()just before returning early.And since we now invoke that logic in two different places, I extracted it into its own function
handle_at_edge(). So really, the only real of this PR is the additional logic introduced on line 410.Off-topic
The noisy diff is largely due to the indentation change. Block out the noise using: