ISSUE-441: apply absolute negative patterns to full path #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmlnc
force-pushed
the
ISSUE-441_absolute_negrative
branch
2 times, most recently
from
c2deef0 to
3ae1a95
Compare
mrmlnc
force-pushed
the
ISSUE-441_absolute_negrative
branch
from
3ae1a95 to
4df40bd
Compare
webpro
approved these changes
Jul 2, 2024
| @@ -67,7 +67,7 @@ | |||
| "test:e2e:stream": "mocha \"out/**/*.e2e.js\" -s 0 --grep \"\\(stream\\)\"", | |||
| "_build:compile": "npm run clean && npm run compile", | |||
| "build": "npm run _build:compile && npm run lint && npm test", | |||
| "watch": "npm run _build:compile -- --sourceMap --watch", | |||
| "watch": "npm run _build:compile -- -- --sourceMap --watch", | |||
There was a problem hiding this comment.
Oh nm, TIL about the double-double dashes :)
There was a problem hiding this comment.
Unfortunately, this is an issue that was already present in the trunk. I have fixed it in the separated commit.
Starting bench:regression:async:deep
Label import.time (time) time (time) memory (memory) entries (value) process.time (time)
----------------- ------------------ ---------------- ------------------- --------------- -------------------
async current ** 10.230ms ±1.810% 83.544ms ±4.436% 16.163 MiB ±3.686% 13792 ±0.000% 133.517ms ±3.298%
async previous ** 23.174ms ±1.867% 99.807ms ±2.693% 13.226 MiB ±18.557% 13792 ±0.000% 157.524ms ±1.846%
Finished bench:regression:async:deep in 43.7s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Fixes #441, based on an idea from #445.
What changes did you make? (Give an overview)
Use only absolute (negated) patterns when matching against absolute paths to skip in filter.