Refactor ops-traefik #1

mrnicegyu11 · 2025-05-12T09:42:25Z

What do these changes do?

Make traefik configurable with env-vars instead of CLI arguments --> Better interoperability with portainer
Remove per-cluster overwrite docker-compose files
Remove unused env-vars and python script

Related issue/s

Related PR/s

https://git.speag.com/oSparc/osparc-ops-deployment-configuration/-/merge_requests/1389/

Checklist

I tested and it works

…onfig via env-vars

YuryHrytsuk

Thanks.

As of now we need docker-compose.master.yml (and Co) to open some ports on a subset of deployments (service exposure) while keeping this services private on other deployments where we do not need it (security)

YuryHrytsuk · 2025-05-13T07:24:17Z

services/traefik/docker-compose.local.yml

@@ -9,7 +9,7 @@ services:
      - "/customEntrypoint.sh"
      - "--api=true"
      - "--api.dashboard=true"
-      - "--log.level=${OPS_TRAEFIK_LOGLEVEL}"
+      - "--log.level=${TRAEFIK_LOG_LEVEL}"


Q: why removing the prefix? Since we have 2 traefiks, it makes sense, oder?

will revert, yes

services/traefik/docker-compose.aws.yml

services/traefik/docker-compose.master.yml

services/traefik/docker-compose.yml.j2

services/traefik/template.env

mrnicegyu11 · 2025-05-13T11:35:19Z

Now using jinja2 logic and env-vars, ports are only opened when needed. The DNS 8.8.8.8 is set everywhere.

YuryHrytsuk · 2025-05-21T09:29:34Z

services/traefik/docker-compose.yml.j2

    configs:
      - source: traefik_dynamic_config.yml
        target: /etc/traefik/dynamic_conf.yml
+    env_file:
+      - .env


It is clear what env_file does.

Why do we now need env inside traefik? What change causes it?

services/traefik/docker-compose.yml.j2

services/traefik/template.env

YuryHrytsuk · 2025-05-21T09:36:03Z

services/traefik/template.env

+TRAEFIK_ENTRYPOINTS_HTTP_TRANSPORT_RESPONDINGTIMEOUTS_IDLETIMEOUT="21600s"
+TRAEFIK_ENTRYPOINTS_HTTP_TRANSPORT_RESPONDINGTIMEOUTS_WRITETIMEOUT="21600s"
+TRAEFIK_ENTRYPOINTS_HTTP_TRANSPORT_RESPONDINGTIMEOUTS_READTIMEOUT="21600s"
+TRAEFIK_ENTRYPOINTS_RABBIT_ADDRESS=":5672"


where is redis port 🤔

Does redis need to be exposed?

Yes

ITISFoundation#1054

services/traefik/docker-compose.yml.j2

YuryHrytsuk · 2025-05-21T09:36:40Z

services/traefik/docker-compose.yml.j2

-      - target: 5433
-        published: 5433
+      {% endif %}
+      {% if OPS_TRAEFIK_EXPOSE_RABBITMQ|lower == "true" %}


Where is redis port?

Does redis need to be exposed?

Yes. See ITISFoundation#1054

services/traefik/docker-compose.yml.j2

YuryHrytsuk

Thanks!

Left some comments

charts/simcore-charts/resource-usage-tracker/values.yaml.gotmpl

* Update longhorn README Document how to perform (kubernetes) node maintenance * Update Longhorn README: disks config and maintenance * Kubernets add local storage Use topolvm as the most mature local storage csi. * Update longhorn readme

mrnicegyu11 · 2025-07-03T14:24:48Z

@YuryHrytsuk

re:

In order to remove duplication of hardcoded values, in a first step I have moved the configuration that used to be passed to traefik as CLI arguments into env-vars. This is supported by traefik according to https://doc.traefik.io/traefik/reference/static-configuration/env/

YuryHrytsuk · 2025-07-04T08:16:10Z

services/logging/docker-compose.yml.j2

@@ -0,0 +1,198 @@
+version: "3.8"


I think this will not work in CI (aka on machines) as our servers have different docker compose verison. It will probably cause version mismatch error and fail in deploy_ops CI

I propose to ditch this label altogether. version is deprecated and is not used anymore (except when define may cause errors)

See https://docs.docker.com/reference/compose-file/version-and-name/#version-top-level-element-obsolete

See example of no version definition in the newest metabase stack ITISFoundation#1093. Works like a charm 🚀

YuryHrytsuk · 2025-07-04T08:17:57Z

services/logging/docker-compose.yml.j2

+        - traefik.http.middlewares.graylog_replace_regex.replacepathregex.regex=^/graylog/?(.*)$$
+        - traefik.http.middlewares.graylog_replace_regex.replacepathregex.replacement=/$${1}
+        - traefik.http.routers.graylog.middlewares=ops_whitelist_ips@swarm, ops_gzip@swarm, graylog_replace_regex
+  fluentd:


hm, this is refactor OPS traefik PR or introduce fluentd / loki PR 🤔

It is true, I made a bad merge and all was mixed :O I will make a fresh PR for traefik ,sorry @YuryHrytsuk

YuryHrytsuk

This is likely a very nice idea to use ENV instead of CLI Arguments as it is indeed easier to work with 👌

Left a few comments. Also seems like fluentd / loki changes go accidentally in but should be done in a separate PR

mrnicegyu11 · 2025-07-08T09:38:06Z

I made a bad merge and the code got mixed up between unrelated PRs (traefik refactoring, loki, fluentd, etc.) :O I will make a fresh PR for traefik and close this one @YuryHrytsuk

mrnicegyu11 added 3 commits May 12, 2025 11:31

Refactor ops-traefik - Remove custom docker compose overwrites, add c…

2249efc

…onfig via env-vars

remove ununsed env-vars

df6482b

rename log-level env-vars

a35cea8

mrnicegyu11 self-assigned this May 12, 2025

mrnicegyu11 marked this pull request as ready for review May 12, 2025 09:43

mrnicegyu11 mentioned this pull request May 12, 2025

Instrument Traefik - Connect traefiks to opentelemetry ITISFoundation/osparc-ops-environments#1041

Open

1 task

mrnicegyu11 requested a review from YuryHrytsuk May 13, 2025 07:22

mrnicegyu11 added the enhancement New feature or request label May 13, 2025

YuryHrytsuk reviewed May 13, 2025

View reviewed changes

mrnicegyu11 added 2 commits May 13, 2025 13:11

Merge remote-tracking branch 'upstream/main' into 2025/refactor/traefik

fb5b138

only bind ports when needed

5234228

mrnicegyu11 requested a review from YuryHrytsuk May 13, 2025 11:34

mrnicegyu11 added 5 commits May 13, 2025 13:38

Add env_file back to traefik compose spec

70c8908

Merge remote-tracking branch 'upstream/main' into 2025/add/fluentd

1cf605d

wip

bcc67d4

Merge remote-tracking branch 'upstream/main' into 2025/refactor/traefik

4fa4f26

Merge remote-tracking branch 'upstream/main' into 2025/refactor/traefik

858c82d

YuryHrytsuk reviewed May 21, 2025

View reviewed changes

services/traefik/docker-compose.yml.j2 Show resolved Hide resolved

Repository owner deleted a comment from mrnicegyu11 May 21, 2025

YuryHrytsuk reviewed May 21, 2025

View reviewed changes

services/traefik/template.env Show resolved Hide resolved

YuryHrytsuk reviewed May 21, 2025

View reviewed changes

services/traefik/docker-compose.yml.j2 Show resolved Hide resolved

YuryHrytsuk reviewed May 21, 2025

View reviewed changes

services/traefik/docker-compose.yml.j2 Show resolved Hide resolved

YuryHrytsuk approved these changes May 21, 2025

View reviewed changes

YuryHrytsuk reviewed May 21, 2025

View reviewed changes

charts/simcore-charts/resource-usage-tracker/values.yaml.gotmpl Outdated Show resolved Hide resolved

mrnicegyu11 added 2 commits May 21, 2025 11:58

Merge remote-tracking branch 'upstream/main' into 2025/add/fluentd

57947e3

Merge remote-tracking branch 'upstream/main' into 2025/add/fluentd

88e4ed5

mrnicegyu11 and others added 4 commits May 28, 2025 15:49

Merge branch '2025/add/fluentd' into 2025/refactor/traefik

1eba82c

Merge branch '2025/add/traefikOpenTelemetry' into 2025/refactor/traefik

236dda9

Merge branch '2025/add/traefikOpenTelemetry' into 2025/refactor/traefik

87875e0

YuryHrytsuk reviewed Jul 4, 2025

View reviewed changes

YuryHrytsuk self-requested a review July 4, 2025 08:19

YuryHrytsuk reviewed Jul 4, 2025

View reviewed changes

mrnicegyu11 added 4 commits July 4, 2025 10:40

Fix deploy_ops CD step - monitoring

b0f1710

Merge remote-tracking branch 'upstream/main' into 2025/refactor/traefik

1970766

wip

221c930

wip

0969ffe

mrnicegyu11 closed this Jul 8, 2025

mrnicegyu11 mentioned this pull request Jul 8, 2025

Refactor: ops-traefik configuration (2nd attempt) ITISFoundation/osparc-ops-environments#1118

Open

1 task

Refactor ops-traefik #1

Refactor ops-traefik #1

Uh oh!

Conversation

mrnicegyu11 commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What do these changes do?

Related issue/s

Related PR/s

Checklist

Uh oh!

YuryHrytsuk left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mrnicegyu11 commented May 13, 2025

Uh oh!

YuryHrytsuk May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

YuryHrytsuk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mrnicegyu11 commented Jul 3, 2025

Uh oh!

YuryHrytsuk Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

YuryHrytsuk Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

YuryHrytsuk left a comment

Choose a reason for hiding this comment

Uh oh!

mrnicegyu11 commented Jul 8, 2025

Uh oh!

Uh oh!

mrnicegyu11 commented May 12, 2025 •

edited

Loading

YuryHrytsuk left a comment •

edited

Loading

YuryHrytsuk May 21, 2025 •

edited

Loading

YuryHrytsuk Jul 4, 2025 •

edited

Loading

YuryHrytsuk Jul 4, 2025 •

edited

Loading