Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove overlay when no animation/class is used #5

Open
mshwery opened this issue Sep 12, 2015 · 2 comments
Open

remove overlay when no animation/class is used #5

mshwery opened this issue Sep 12, 2015 · 2 comments
Labels

Comments

@mshwery
Copy link
Owner

mshwery commented Sep 12, 2015

use a timeout, or some other means to remove the overlay if no animation end event fires for fading out the image.

@mshwery mshwery added the bug label Sep 12, 2015
@thomas-lebeau
Copy link
Contributor

In what case does it not fire?

An alternative is to keep the overlay in the DOM and give it display:none in the keyframe.
The advantage is that you have the overlay ready for next zoom.

@mshwery
Copy link
Owner Author

mshwery commented Sep 12, 2015

TBH I haven't tested that this actually is a bug, but wanted to leave a note that I should test what happens when there is no fade-out to trigger animation end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants