Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win MSI | Fail if version isn't supported at all #166

Open
tmontes opened this issue Aug 26, 2021 · 0 comments
Open

Win MSI | Fail if version isn't supported at all #166

tmontes opened this issue Aug 26, 2021 · 0 comments
Labels
bug Something isn't working @ plugin : win
Milestone

Comments

@tmontes
Copy link
Member

tmontes commented Aug 26, 2021

FACTS:

...
I wix candle out: manifest.wxs
I wix candle out: puppy 2021.8.26.wxs
I wix candle out: C:\Users\test\Work\github.com\puppy.git\build\pup\puppy 2021.8.26.wix-sources\puppy 2021.8.26.wxs(5) : error CNDL0242 : Invalid product version '2021.8.26'. Product version must have a major version less than 256, a minor version less than 256, and a build version less than 65536.
I wix light out: light.exe : error LGHT0093 : Could not find entry section in provided list of intermediates. Expected section of type 'Product'.
I MSI file at 'dist\\puppy 2021.8.26.msi'.
I Step 'win.create-msi': completed.
...
  • pup execution does not fail in these cases, however.

ALSO:

  • MSI BUILD, the third dot-separated integer, cannot be larger than 65535.

WHAT WE WANT:

  • pup to fail if no MSI file is produced.
@tmontes tmontes added bug Something isn't working @ plugin : win labels Aug 26, 2021
@tmontes tmontes added this to the LATER milestone Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working @ plugin : win
Projects
None yet
Development

No branches or pull requests

1 participant