Skip to content

$query, $extension 和 $children 的属性不能重名但又没有正确的错误提示 #89

Open
@noobnooc

Description

@noobnooc

Makeflow task reference: https://staging.makeflow.io/app/?_redirect=/task/3223
比如有以下路由定义:

efforts: {
    $exact: true,
    $children: {
      team: {      // 1: $children 里的 team
        $exact: true,
        $query: {
          range: true,
          team: true,  // 2: $query 里的 team
        },
      },
    },
    $extension: {
      range: undefined as string | undefined,
      team: undefined as Team | undefined,   // 3: $extension 里的 team
    },
}

其中 `1` `2` `3` 中的 team 是冲突的,但 Boring Router 本身并不会报错或报错信息混乱从而导致一些看起来难以排查的 bug。可考虑改成命名互不冲突或者在定义时就报出提示信息明确的错误。

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions