fix: ignore invalid brightness value for dim duration

Author: muhlba91

custom_components/hella_onyx/manifest.json

@@ -5,7 +5,7 @@
   "documentation": "https://github.com/muhlba91/onyx-homeassistant-integration",
   "issue_tracker": "https://github.com/muhlba91/onyx-homeassistant-integration/issues",
   "requirements": [
-    "onyx-client==8.1.2"
+    "onyx-client==8.1.3"
   ],
   "ssdp": [],
   "zeroconf": [],

custom_components/hella_onyx/sensors/light.py

@@ -130,6 +130,13 @@ def turn_off(self, **kwargs: Any) -> None:
     def _get_dim_duration(self, target) -> int:
         """Get the dim duration."""
         brightness = self._device.actual_brightness
+        if brightness is None or brightness.value is None or brightness.maximum is None:
+            _LOGGER.warning(
+                "received light %s without a valid brightness value: %s",
+                self._uuid,
+                brightness,
+            )
+            return MIN_USED_DIM_DURATION
         return abs(
             int(
                 (target - brightness.value)

poetry.lock

@@ -27,7 +27,7 @@ classifiers = [
 
 [tool.poetry.dependencies]
 python = "^3.11"
-onyx-client = "^8.1.2"
+onyx-client = "^8.1.3"
 
 [tool.poetry.dev-dependencies]
 pytest = "^7.3.1"

pyproject.toml

@@ -150,3 +150,25 @@ def test__get_dim_duration_same(self, api, entity, device):
         api.device.return_value = device
         assert entity._get_dim_duration(100) == 500
         assert api.device.called
+
+    def test__get_dim_duration_invalid_value(self, api, entity, device):
+        device.actual_brightness = NumericValue(
+            value=None, maximum=100, minimum=0, read_only=False
+        )
+        api.device.return_value = device
+        assert entity._get_dim_duration(90) == 500
+        assert api.device.called
+
+    def test__get_dim_duration_invalid_maximum(self, api, entity, device):
+        device.actual_brightness = NumericValue(
+            value=10, maximum=None, minimum=0, read_only=False
+        )
+        api.device.return_value = device
+        assert entity._get_dim_duration(90) == 500
+        assert api.device.called
+
+    def test__get_dim_duration_invalid_brightness(self, api, entity, device):
+        device.actual_brightness = None
+        api.device.return_value = device
+        assert entity._get_dim_duration(90) == 500
+        assert api.device.called