fix: set dim duration correctly; add tests for dim duration variations

Author: muhlba91

custom_components/hella_onyx/sensors/light.py

@@ -239,7 +239,7 @@ def _get_dim_duration(self, target) -> int:
         brightness = self._actual_brightness
         return abs(
             int(
-                (target - brightness.value)
+                abs(target - brightness.value)
                 / brightness.maximum
                 * (MAX_USED_DIM_DURATION - MIN_USED_DIM_DURATION)
                 + MIN_USED_DIM_DURATION

tests/sensors/test_light.py

@@ -186,7 +186,7 @@ def test_turn_on(self, mock_run_coroutine_threadsafe, api, entity, device):
             "uuid",
             {
                 "target_brightness": 4,
-                "dim_duration": 4780,
+                "dim_duration": 5780,
             },
         )
         assert mock_run_coroutine_threadsafe.called
@@ -208,14 +208,6 @@ def test_turn_on_no_brightness(
         assert mock_run_coroutine_threadsafe.called
         assert not api.device.called
 
-    def test__get_dim_duration(self, api, entity, device):
-        device.actual_brightness = NumericValue(
-            value=14645, maximum=65535, minimum=0, read_only=False
-        )
-        api.device.return_value = device
-        assert entity._get_dim_duration(31) == 726
-        assert api.device.called
-
     def test__actual_brightness_no_value(self, api, entity, device):
         device.actual_brightness = NumericValue(
             value=None, maximum=100, minimum=0, read_only=False
@@ -232,6 +224,14 @@ def test__actual_brightness(self, api, entity, device):
         assert entity._actual_brightness == NumericValue(1, 0, 100, False)
         assert api.device.called
 
+    def test__get_dim_duration(self, api, entity, device):
+        device.actual_brightness = NumericValue(
+            value=14645, maximum=65535, minimum=0, read_only=False
+        )
+        api.device.return_value = device
+        assert entity._get_dim_duration(31) == 1726
+        assert api.device.called
+
     def test__get_dim_duration_same(self, api, entity, device):
         device.actual_brightness = NumericValue(
             value=100, maximum=100, minimum=0, read_only=False
@@ -248,6 +248,22 @@ def test__get_dim_duration_invalid_value(self, api, entity, device):
         assert entity._get_dim_duration(90) == 5450
         assert api.device.called
 
+    def test__get_dim_duration_actual_lower_than_new(self, api, entity, device):
+        device.actual_brightness = NumericValue(
+            value=0, maximum=65535, minimum=0, read_only=False
+        )
+        api.device.return_value = device
+        assert entity._get_dim_duration(65535) == 6000
+        assert api.device.called
+
+    def test__get_dim_duration_new_lower_than_actual(self, api, entity, device):
+        device.actual_brightness = NumericValue(
+            value=65535, maximum=65535, minimum=0, read_only=False
+        )
+        api.device.return_value = device
+        assert entity._get_dim_duration(0) == 6000
+        assert api.device.called
+
     @patch("asyncio.run_coroutine_threadsafe")
     def test_start_dim_device_within_time(self, entity):
         current_time = time.time()