Bug: toast.promise ignores success.timeout and error.timeout values

[joaorr3]

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch @base-ui-components/react@1.0.0-beta.0 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/@base-ui-components/react/esm/toast/provider/ToastProvider.js b/node_modules/@base-ui-components/react/esm/toast/provider/ToastProvider.js
index d30a3d2..94b8fe7 100644
--- a/node_modules/@base-ui-components/react/esm/toast/provider/ToastProvider.js
+++ b/node_modules/@base-ui-components/react/esm/toast/provider/ToastProvider.js

@@ -218,21 +218,23 @@ export const ToastProvider = function ToastProvider(props) {
       type: 'loading'
     });
     const handledPromise = promiseValue.then(result => {
+      const successOptions = resolvePromiseOptions(options.success, result);
       update(id, {
-        ...resolvePromiseOptions(options.success, result),
+        ...successOptions,
         type: 'success'
       });
-      scheduleTimer(id, timeout, () => close(id));
+      scheduleTimer(id, successOptions.timeout ?? timeout, () => close(id));
       if (hoveringRef.current || focusedRef.current || !windowFocusedRef.current) {
         pauseTimers();
       }
       return result;
     }).catch(error => {
+      const errorOptions = resolvePromiseOptions(options.error, error);
       update(id, {
-        ...resolvePromiseOptions(options.error, error),
+        ...errorOptions,
         type: 'error'
       });
-      scheduleTimer(id, timeout, () => close(id));
+      scheduleTimer(id, errorOptions.timeout ?? timeout, () => close(id));
       if (hoveringRef.current || focusedRef.current || !windowFocusedRef.current) {
         pauseTimers();
       }

This issue body was partially generated by patch-package.

[mj12albert]

@joaorr3 Would you mind sharing a simple repro of the bug?

[joaorr3]

@mj12albert Is that really necessary since the #2294 fixes the issue?

[atomiks]

@joaorr3 no need to worry, the issue was clear to me

[github-actions]

This feature will be available in the next npm release of Base UI.

In the meantime, you can try it out on our Canary release channel:

npm i https://pkg.pr.new/@base-ui-components/react@2294