Skip to content

[select] Support conditional multiple prop in types #2369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 26, 2025

Conversation

atomiks
Copy link
Contributor

@atomiks atomiks commented Jul 25, 2025

Uses conditional types instead of overloads for multiple so as to support multiple={condition}

Closes #2368

@mui-bot
Copy link

mui-bot commented Jul 25, 2025

Bundle size report

Bundle Parsed Size Gzip Size
@base-ui-components/react 🔺+5B(0.00%) 🔺+3B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against b84951f

Copy link

pkg-pr-new bot commented Jul 25, 2025

vite-css-base-ui-example

pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/react@2369
pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/utils@2369

commit: b84951f

Copy link

netlify bot commented Jul 25, 2025

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit b84951f
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/68841e4f3b194c00080ed69e
😎 Deploy Preview https://deploy-preview-2369--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@atomiks atomiks force-pushed the fix/select-multiple-type branch 2 times, most recently from 2b8a2d9 to 653405c Compare July 25, 2025 02:39
@atomiks atomiks force-pushed the fix/select-multiple-type branch from 653405c to 607cdcf Compare July 25, 2025 02:42
@atomiks atomiks marked this pull request as ready for review July 25, 2025 02:47
@atomiks atomiks merged commit 8dda8cd into mui:master Jul 26, 2025
21 checks passed
@atomiks atomiks deleted the fix/select-multiple-type branch July 26, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[select] Canary Release Mis-Types the Multiple Option for Select.Root
3 participants