Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Flaky argos test docs-getting-started-templates-dashboard-components/MainGrid.png #43962

Closed
albarv340 opened this issue Oct 2, 2024 · 4 comments
Labels
scope: code-infra Specific to the core-infra product

Comments

@albarv340
Copy link
Contributor

albarv340 commented Oct 2, 2024

Steps to reproduce

Link to live example:
This passes: https://app.argos-ci.com/mui/material-ui/builds/32244/109849143
This doesn't pass: https://app.argos-ci.com/mui/material-ui/builds/32247/109855836
Nothing that effected the MainGrid changed, and it started failing.

Steps:

  1. Make pull request and let argos run its course

Current behavior

The docs-getting-started-templates-dashboard-components/MainGrid.png test says it has been changed, even though none of the files affecting it have been touched.

Expected behavior

The docs-getting-started-templates-dashboard-components/MainGrid.png test should only say it has been changed if it has actually been changed.

Context

Creating a pull request, of something unrelated to this failing test. I encountered the same issue on multiple different pull requests.

Your environment

No response

Search keywords: docs-getting-started-templates-dashboard-components/MainGrid.png flaky argos

@albarv340 albarv340 added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 2, 2024
@mnajdova
Copy link
Member

mnajdova commented Oct 2, 2024

We recently merged a PR to fix this test. Can you update to latest master and check if it is still happening?

@mnajdova mnajdova added scope: code-infra Specific to the core-infra product status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 2, 2024
@albarv340
Copy link
Contributor Author

It does seem to be fixed, at least as far as I can see now. I didn't have time to create an issue when I last saw it yesterday, and I didn't notice it had been fixed since then. My bad!

@github-actions github-actions bot added status: waiting for maintainer These issues haven't been looked at yet by a maintainer and removed status: waiting for author Issue with insufficient information labels Oct 2, 2024
@mnajdova
Copy link
Member

mnajdova commented Oct 2, 2024

Cool, alright, I am closing it.

@mnajdova mnajdova closed this as completed Oct 2, 2024
Copy link

github-actions bot commented Oct 2, 2024

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Note

We value your feedback @albarv340! How was your experience with our support team?
We'd love to hear your thoughts in this brief Support Satisfaction survey. Your insights help us improve!

@github-actions github-actions bot removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: code-infra Specific to the core-infra product
Projects
None yet
Development

No branches or pull requests

2 participants