Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v6][Checkbox] disableRipple not working #44063

Closed
Tasin5541 opened this issue Oct 11, 2024 · 2 comments · Fixed by #44099
Closed

[v6][Checkbox] disableRipple not working #44063

Tasin5541 opened this issue Oct 11, 2024 · 2 comments · Fixed by #44099
Labels
bug 🐛 Something doesn't work component: checkbox This is the name of the generic UI component, not the React module! regression A bug, but worse

Comments

@Tasin5541
Copy link

Tasin5541 commented Oct 11, 2024

Steps to reproduce

Link to live example: https://stackblitz.com/edit/react-scpwxs?file=Demo.tsx

Steps:

  1. Add disableRipple prop to Checkbox component
  2. Click on the checkbox
  3. The ripple effect persists

Current behavior

Ripple effects persist even after adding disableRipple

Expected behavior

Ripple effects should not be there after adding disableRipple

Context

We noticed this bug after upgrading to MUI v6 from MUI v5. This used to work properly in the latest MUI v5

Your environment

npx @mui/envinfo
  System: OS: Windows 11 10.0.22631
  Binaries:
    Node: 20.12.2 - C:\Program Files\nodejs\node.EXE
    npm: 10.5.0 - C:\Program Files\nodejs\npm.CMD
    pnpm: Not Found
  Browsers:
    Chrome: Not Found
    Edge: Spartan (23.15.3), Chromium (23.15.3), ChromiumDev (23.15.3)
  npmPackages:
    @emotion/react: ^11.13.3 => 11.13.3
    @emotion/styled: ^11.13.0 => 11.13.0
    @mui/core-downloads-tracker:  6.1.2
    @mui/icons-material: ^6.1.2 => 6.1.2
    @mui/material: ^6.1.2 => 6.1.2
    @mui/private-theming:  6.1.2
    @mui/styled-engine:  6.1.2
    @mui/system:  6.1.2
    @mui/types:  7.2.17
    @mui/utils:  6.1.2
    @types/react: ^18.3.11 => 18.3.11
    react: ^18.3.1 => 18.3.1
    react-dom: ^18.3.1 => 18.3.1
    typescript: ^5.2.2 => 5.5.3

Search keywords: disableRipple, disable ripple, checkbox disableRipple

@Tasin5541 Tasin5541 added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 11, 2024
@oliviertassinari oliviertassinari changed the title [MUI v6] [Checkbox] disableRipple not working [v6] [Checkbox] disableRipple not working Oct 11, 2024
@siriwatknp siriwatknp added regression A bug, but worse component: switch This is the name of the generic UI component, not the React module! component: checkbox This is the name of the generic UI component, not the React module! and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer component: switch This is the name of the generic UI component, not the React module! labels Oct 14, 2024
@siriwatknp
Copy link
Member

siriwatknp commented Oct 14, 2024

Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Note

@Tasin5541 How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Oct 14, 2024
@oliviertassinari oliviertassinari changed the title [v6] [Checkbox] disableRipple not working [v6][Checkbox] disableRipple not working Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: checkbox This is the name of the generic UI component, not the React module! regression A bug, but worse
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants