-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui] Prevent ownerState
propagation for transition slots
#44401
base: master
Are you sure you want to change the base?
[material-ui] Prevent ownerState
propagation for transition slots
#44401
Conversation
Netlify deploy previewhttps://deploy-preview-44401--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
ownerState
propagation in accordion transition slotownerState
propagation for transition slots
ownerState
propagation for transition slotsownerState
propagation for transition slots
Co-authored-by: Olivier Tassinari <[email protected]> Signed-off-by: Zeeshan Tamboli <[email protected]>
Hey @ZeeshanTamboli, thanks for working on this. We do want the The fix here should be to filter out the |
Found this while investigating an issue—check the console error about
ownerState
.Before: Sandbox
After: Sandbox
You can also see it in the local Accordion docs at
http://localhost:3000/material-ui/react-accordion/
.The workaround in #40418 was removed in favor of #41187, but #41187 doesn’t handle custom transition slots like Fade and Zoom.
This PR introduces a new
shouldAppendOwnerState
option inuseSlot
, preventingownerState
from being appended unnecessarily, instead of appending and then removing it.