Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix EditingWithDatePickers demo #15967

Merged
merged 10 commits into from
Dec 31, 2024
Merged

Conversation

k-rajat19
Copy link
Contributor

@k-rajat19 k-rajat19 commented Dec 21, 2024

@k-rajat19 k-rajat19 marked this pull request as ready for review December 21, 2024 14:22
@mui-bot
Copy link

mui-bot commented Dec 21, 2024

Deploy preview: https://deploy-preview-15967--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 6b5fd3d

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@zannager zannager added docs Improvements or additions to the documentation component: pickers This is the name of the generic UI component, not the React module! labels Dec 30, 2024
Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I would like a second review on this.

@michelengelen
Copy link
Member

michelengelen commented Dec 30, 2024

Hey @k-rajat19 ... could you merge master to resolve the conflicts? Thanks!

return (
<Component
value={value}
autoFocus
enableAccessibleFieldDOMStructure={false}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid showcasing behavior that will no longer be the default for v8. 🙏

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated 👍

@k-rajat19 k-rajat19 force-pushed the editing-date-pickers branch from ca62d85 to 430a68d Compare December 31, 2024 06:20
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 31, 2024
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! 🙏

@LukasTy LukasTy added needs cherry-pick The PR should be cherry-picked to master after merge v7.x component: data grid This is the name of the generic UI component, not the React module! labels Dec 31, 2024
@LukasTy LukasTy merged commit 390211c into mui:master Dec 31, 2024
24 checks passed
Copy link

Cherry-pick PRs will be created targeting branches: v7.x

github-actions bot pushed a commit that referenced this pull request Dec 31, 2024
@k-rajat19 k-rajat19 deleted the editing-date-pickers branch December 31, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! component: pickers This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation needs cherry-pick The PR should be cherry-picked to master after merge v7.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[data grid] Tab key functionality is broken when using DatePicker within the MUI DataGrid
5 participants