-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Fix EditingWithDatePickers
demo
#15967
Conversation
Deploy preview: https://deploy-preview-15967--material-ui-x.netlify.app/ |
…o editing-date-pickers
inputRef.current.focus
on accessibleFieldDOMStructure
#15985
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I would like a second review on this.
Hey @k-rajat19 ... could you merge master to resolve the conflicts? Thanks! |
return ( | ||
<Component | ||
value={value} | ||
autoFocus | ||
enableAccessibleFieldDOMStructure={false} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please avoid showcasing behavior that will no longer be the default for v8. 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated 👍
ca62d85
to
430a68d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! 🙏
Cherry-pick PRs will be created targeting branches: v7.x |
Closes #15965
https://deploy-preview-15967--material-ui-x.netlify.app/x/react-data-grid/custom-columns/#date-pickers