-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Closed
Labels
scope: data gridChanges related to the data grid.Changes related to the data grid.status: waiting for authorIssue with insufficient information.Issue with insufficient information.type: bugIt doesn't behave as expected.It doesn't behave as expected.
Description
Steps to reproduce
Steps:
- Open this link to live example: (required)
mui-x/docs/data/data-grid/editing/FullFeaturedCrudGrid.tsx
Lines 73 to 80 in 4a649f2
declare module '@mui/x-data-grid' { interface ToolbarPropsOverrides { setRows: (newRows: (oldRows: GridRowsProp) => GridRowsProp) => void; setRowModesModel: ( newModel: (oldModel: GridRowModesModel) => GridRowModesModel, ) => void; } }
Current behavior
GridToolbarProps is missing these two functions. If there's a reason the interface doesn't have them, it's not documented.
Expected behavior
I would expect to not have to declare these types myself. I would assume we should be able to add these to GridToolbarProps and remove the unnecessary complication of needing to have users extend the declaration.
Context
I'm trying to upgrade to v7 and encountered this as a typescript error and had to search through the docs thinking I was doing something wrong.
Your environment
npx @mui/envinfo
System:
OS: Linux 5.15 Ubuntu 20.04.6 LTS (Focal Fossa)
Binaries:
Node: 16.20.2 - /usr/bin/node
npm: 8.19.4 - /usr/bin/npm
pnpm: 8.15.6 - /usr/bin/pnpm
Browsers:
Chrome: 131.0.6778.108
Search keywords: data-grid
Order ID:
Metadata
Metadata
Assignees
Labels
scope: data gridChanges related to the data grid.Changes related to the data grid.status: waiting for authorIssue with insufficient information.Issue with insufficient information.type: bugIt doesn't behave as expected.It doesn't behave as expected.