Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Update l10n script for pickers #4914

Closed
alexfauquette opened this issue May 17, 2022 · 4 comments
Closed

[core] Update l10n script for pickers #4914

alexfauquette opened this issue May 17, 2022 · 4 comments
Assignees
@alexfauquette
Labels
component: pickers This is the name of the generic UI component, not the React module! l10n localization

Comments

@alexfauquette
Copy link
Member

alexfauquette commented May 17, 2022 •
edited
Loading

Follow up of #4517

The idea is to update #3211 with missing translation from the pickers

I'm wondering if we should include them in the existing issue or rename it

  • Help us to translate the data grid
  • Help us to translate the pickers
@alexfauquette alexfauquette changed the title [core] Update script to put all the remaining translations in an issue [core] Update l10n script for pickers May 17, 2022
@alexfauquette alexfauquette added the l10n localization label May 17, 2022
@alexfauquette alexfauquette mentioned this issue May 17, 2022
Merged
2 tasks
@alexfauquette alexfauquette added the component: pickers This is the name of the generic UI component, not the React module! label May 17, 2022
@flaviendelangle
Copy link
Member

The current data grid issue is very long, I would be in favor of creating a different one for the pickers and rename the existing one as you proposed (@m4theushw)

@m4theushw
Copy link
Member

We could limit the number of translations missing shown in each locale in #3211. This would help to reduce the noise. There're some locales that are too outdated, e.g. zh-CN.

Another option is to not use the permalink as text, but render only the key missing. As example, #2081 contains as much information as #3211 but doesn't feel overwhelmed.

@alexfauquette
Copy link
Member Author

What about a tree structure like that something like that?

🇸🇩 ar-SD
data grid
  • toolbarQuickFilterPlaceholder: 'Search...' l31
  • toolbarQuickFilterLabel: 'Search' l32
pickers
  • TODO

@m4theushw
Copy link
Member

m4theushw commented May 18, 2022 •
edited
Loading

We can explore using collapsible sections. What do you think of?

I don't think we should add the line number because the link already points to it.

🇸🇩 ar-SD

DataGrid, DataGridPro and DataGridPremium
Date and Time Pickers

🇧🇬 bg-BG

DataGrid / DataGridPro / DataGridPremium
Date and Time Pickers

@alexfauquette alexfauquette mentioned this issue May 18, 2022
Merged
@alexfauquette alexfauquette self-assigned this Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexfauquette alexfauquette

Labels
component: pickers This is the name of the generic UI component, not the React module! l10n localization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@flaviendelangle @m4theushw @alexfauquette