Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[studio] Cell shouldn't be editable by default #3524

Open
oliviertassinari opened this issue May 5, 2024 · 3 comments · May be fixed by #3526
Open

[studio] Cell shouldn't be editable by default #3524

oliviertassinari opened this issue May 5, 2024 · 3 comments · May be fixed by #3526
Labels
bug 🐛 Something doesn't work good first issue Great for first contributions. Enable to learn the contribution process. regression A bug, but worse scope: toolpad-studio Abbreviated to "studio"

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented May 5, 2024 •
edited
Loading

Steps to reproduce

  1. Open https://tools-public.mui.com/prod/pages/baseUiNpmKpis
  2. 🙃
Screen.Recording.2024-05-05.at.18.16.29.mov

Context

I suspect #3001 is the origin of this regression. I noticed this one on the same app that I noticed the other regressions from (the Zendesk plugin), while I was fixing https://github.com/mui/mui-private/pull/470.

Benchmarks

  • Retool does this right:
SCR-20240505-qafn
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work regression A bug, but worse status: waiting for maintainer These issues haven't been looked at yet by a maintainer scope: toolpad-studio Abbreviated to "studio" labels May 5, 2024
@b4s36t4
Copy link
Contributor

b4s36t4 commented May 5, 2024

Hi, @oliviertassinari. Would love to take up this issue, but I'm stuck at understanding the issue.

  • Currently by default all cells are editable, which shouldn't be the case.
  • We should let the user choose which column should be editable in the properties panel.

This is what I did understand, please let me know if it's not the case, and in case the it's same is it possible for me take up this one?

@Janpot
Copy link
Member

Janpot commented May 6, 2024 •
edited
Loading

@b4s36t4 The data grid should only be editable when it is linked to a data provider that supports editing rows. In all other cases there won't be any logic available to handle the row updates, so having the grid editable makes no sense.

As you may notice in the live example, you can change the value of the cel, but as soon as you exit editing mode, the value is reset again. This is meant to be a static grid, output only.

@Janpot Janpot added good first issue Great for first contributions. Enable to learn the contribution process. and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels May 6, 2024
@b4s36t4 b4s36t4 linked a pull request May 6, 2024 that will close this issue
Open
4 tasks
@b4s36t4
Copy link
Contributor

b4s36t4 commented May 6, 2024

@Janpot I have raised a PR, please check it.!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work good first issue Great for first contributions. Enable to learn the contribution process. regression A bug, but worse scope: toolpad-studio Abbreviated to "studio"
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/default editable grid b4s36t4/mui-toolpad
3 participants
@Janpot @oliviertassinari @b4s36t4