Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow per-domain proxies to be configured with wildcards #232

Open
curlingchimpanzeeowl opened this issue Aug 16, 2024 · 5 comments
Open
Labels
proxy This is related to the socks proxy feature

Comments

@curlingchimpanzeeowl
Copy link

For example, if I set up my connection to *.example.com to use bg-sof-wg-101, I want maps.example.com, login.example.com, and payments.example.com to use bg-sof-wg-101 as well.

@ruihildt
Copy link
Member

ruihildt commented Aug 16, 2024

After thinking about it, the plan is to have a wildcard by default, when you add though the popup for the current website.
But if you manually enter a domain with subdomain, then the more specific (sub-domain), will take precedence.

Do you think that makes sense?

@ruihildt ruihildt added the proxy This is related to the socks proxy feature label Aug 16, 2024
@issuant
Copy link

issuant commented Aug 31, 2024

Do you think that makes sense?

If this then a very obnoxious warning should be shown to the user before they are allowed to save a new entry.

@cohesive-flight
Copy link

cohesive-flight commented Nov 8, 2024

In the v0.9.3 beta, wildcards still get proxied even when setting it to never do so. It's also a bit difficult to find this option, as you would assume the arrow that reveals it is associated with the locations to select since it's right next to it. Furthermore, the domain specified gets wiped before finalizing a location to proxy it to. So if you ever back out from selecting a location due to mistyping it or wanting to never proxy it instead, you'd have to retype it entirely.

@ruihildt
Copy link
Member

ruihildt commented Nov 8, 2024

Wildcard is not yet supported. To give you an example, if you setup a proxy ip.me, it will not apply to www.ip.me.

Regarding the difficulty about finding the "never proxy" option, where would you expect it to appear?

@ruihildt
Copy link
Member

ruihildt commented Nov 8, 2024

I opened as separate issue (#255) for your other feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proxy This is related to the socks proxy feature
Projects
Development

No branches or pull requests

4 participants