Skip to content

Commit 5e14365

Browse files
committed
Fix MTA freeze in fopen hook from recursive file I/O
AddReportLog() in the fopen failure path called FileAppend > File::Fopen, creating recursive file I/O inside the hook. This froze when AcLayers.DLL (Windows compatibility component) intercepted the nested CreateFileW call. Debug info is still saved via registry (SetApplicationSetting) Removing the log line isn't ideal, but there ain't really an alternative.
1 parent b427dfd commit 5e14365

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

Client/multiplayer_sa/CMultiplayerSA_Files.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ void OnMY_Rtl_fopen_Post(FILE* fh, DWORD calledFrom, const char* szFilename, con
3939
return;
4040
}
4141

42-
AddReportLog(5321, SString("Rtl_fopen failed: called from:%08x mode:%s name:%s", calledFrom, szMode, *strFilename));
4342
SetApplicationSetting("diagnostics", "gta-fopen-fail", strFilename);
4443
}
4544
}

0 commit comments

Comments
 (0)