From 4ae1dff6ad206c5582040d1d31a0f60a68b439e5 Mon Sep 17 00:00:00 2001 From: Murch Date: Fri, 1 Mar 2024 15:42:08 -0500 Subject: [PATCH] [test] Remove redundant repeated test We do not need to repeat the same test multiple times because BnB is deterministic and will therefore always have the same outcome. Additionally, this test was redundant because it repeats the "Smallest combination too big" test. --- src/wallet/test/coinselector_tests.cpp | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/wallet/test/coinselector_tests.cpp b/src/wallet/test/coinselector_tests.cpp index 4f4d030aaf461c..fd79934d5d45c4 100644 --- a/src/wallet/test/coinselector_tests.cpp +++ b/src/wallet/test/coinselector_tests.cpp @@ -209,15 +209,6 @@ BOOST_AUTO_TEST_CASE(bnb_search_test) //////////////////// // Behavior tests // //////////////////// - // Select 1 Cent with pool of only greater than 5 Cent - utxo_pool.clear(); - for (int i = 5; i <= 20; ++i) { - add_coin(i * CENT, i, utxo_pool); - } - // Run 100 times, to make sure it is never finding a solution - for (int i = 0; i < 100; ++i) { - BOOST_CHECK(!SelectCoinsBnB(GroupCoins(utxo_pool), 1 * CENT, 2 * CENT)); - } // Make sure that effective value is working in AttemptSelection when BnB is used CoinSelectionParams coin_selection_params_bnb{