Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of non-reduced form for dynamic Action and Signal names #284

Open
justparking opened this issue Feb 21, 2023 · 1 comment
Open

Use of non-reduced form for dynamic Action and Signal names #284

justparking opened this issue Feb 21, 2023 · 1 comment
Assignees

Comments

@justparking
Copy link
Contributor

Due to a legacy restriction of the frontend at the time, the nodel backend automatically "reduces" the names of dynamic actions and events.

The key place where this occurs is in ManagedToolkit.java line#742ish:

    public NodelServerEvent createEvent(String eventName, Binding metadata) {
...
            NodelServerEvent event = new NodelServerEvent(_node.getName(), new SimpleName(Nodel.reduce(eventName)), metadata);
...

Note the Nodel.reduce(eventName) which takes place in that method and others (createAction(...)).

Ideally it should not be reduced and left as is. The backend of nodel quite happily deals with the longer forms but, as mentioned, the frontend had issues dealing with spaces, hypens or underscores sometimes when dynamic actions & events were introduced. Previously they were defined declaritively as part of python variable names (e.g. local_event_Output1Volume) so they had inherent naming restrictions. When they're dynamically created naming restrictions are not needed (e.g. Output 1 Volume).

The issue is I'm not sure how the rest of the frontend code (Javascript) copes with un-sanitised names of actions and events so this needs to be tested thoroughly.

It's possible their names need to be processed before they can be dealt with efficiently. Note, that whatever method is decided it need to be highly efficient and able to cope with high quantities of actions of events.

Using the non-reduced form should make bindings much more readable and likely more "matchable" when using the fuzzy-logic autofill method. And I'm hoping with the proposed search behaviour improvement in #283, it should assist with completing mass bindings.

(@scroix, @mcartmel, @dargs FYI)

@morimoriysmoon
Copy link
Contributor

A new branch added. It also supports improved search.
https://github.com/morimoriysmoon/nodel/tree/feat-standardise-search
image
image

scroix added a commit to scroix/nodel that referenced this issue Apr 4, 2024
… Actions and Events

- These are in preparation for changes related to issue museumsvictoria#284
scroix added a commit to scroix/nodel that referenced this issue Apr 6, 2024
… Actions and Events

- These are in preparation for changes related to issue museumsvictoria#284
scroix added a commit to scroix/nodel that referenced this issue Apr 20, 2024
… Actions and Events

- These are in preparation for changes related to issue museumsvictoria#284
scroix added a commit to scroix/nodel that referenced this issue Apr 20, 2024
commit 1b9e15b
Author: scroix <[email protected]>
Date:   Fri Apr 19 18:46:43 2024 +1000

    Revert to Java 8 compatible logback dependency

commit ca5bc00
Author: scroix <[email protected]>
Date:   Sat Apr 20 12:19:25 2024 +1000

    Revert "Merge branch 'feature/introduce-junit-testing' of github.com:scroix/nodel into feature/introduce-junit-testing"

    This reverts commit 50dfbcb, reversing
    changes made to b1a73ad.

commit 50dfbcb
Merge: b1a73ad d9830bc
Author: scroix <[email protected]>
Date:   Sat Apr 20 12:15:05 2024 +1000

    Merge branch 'feature/introduce-junit-testing' of github.com:scroix/nodel into feature/introduce-junit-testing

    # Conflicts:
    #	nodel-framework/build.gradle
    #	nodel-framework/src/test/java/org/nodel/SimpleNameTest.java

commit b1a73ad
Author: scroix <[email protected]>
Date:   Thu Apr 4 17:42:25 2024 +1100

    Add first ever JUnit tests

    - Cover SimpleNameTest with a couple of test cases
    - Ensure they pass

commit 9a0ebd2
Author: scroix <[email protected]>
Date:   Thu Apr 4 17:41:21 2024 +1100

    Add JUnit as a testing framework

    - Configure Gradle build to include JUnit dependencies

commit 1198db3
Author: scroix <[email protected]>
Date:   Fri Apr 5 09:17:53 2024 +1100

    Introduce test cases to cover expected names of dynamically generated Actions and Events

    - These are in preparation for changes related to issue museumsvictoria#284

commit da01834
Author: scroix <[email protected]>
Date:   Fri Apr 5 09:16:42 2024 +1100

    Add GitHubIssue annotation to mark up tests

commit a1c0e13
Author: scroix <[email protected]>
Date:   Fri Apr 5 09:15:51 2024 +1100

    minor: Remove public declaration from SimpleNameTest

commit c04baf2
Author: scroix <[email protected]>
Date:   Fri Apr 5 09:14:50 2024 +1100

    Add Mockito and Logback test dependencies

commit 2daa92b
Author: scroix <[email protected]>
Date:   Thu Apr 4 17:42:25 2024 +1100

    Add first ever JUnit tests

    - Cover SimpleNameTest with a couple of test cases
    - Ensure they pass

commit 14b7033
Author: scroix <[email protected]>
Date:   Thu Apr 4 17:41:21 2024 +1100

    Add JUnit as a testing framework

    - Configure Gradle build to include JUnit dependencies

commit d9830bc
Author: scroix <[email protected]>
Date:   Fri Apr 19 18:46:43 2024 +1000

    Revert to Java 8 compatible logback dependency

commit e74f409
Author: scroix <[email protected]>
Date:   Sat Apr 6 16:11:43 2024 +1100

    Revert to original parent build file

commit 128dbe2
Author: scroix <[email protected]>
Date:   Sat Apr 6 16:10:18 2024 +1100

    Re-add Gradle job for running tests

commit 6a0ed30
Author: scroix <[email protected]>
Date:   Sat Apr 6 16:08:20 2024 +1100

    Revert "minor: ignore IntelliJ IDE files"

    This reverts commit 9a23d63.

commit 08e99fe
Author: scroix <[email protected]>
Date:   Sat Apr 6 16:04:59 2024 +1100

    Manually 'rebase' in preparation for PR

commit 2ff6dda
Merge: e386b21 1440a78
Author: Julien de-Sainte-Croix <[email protected]>
Date:   Sat Apr 6 15:21:28 2024 +1100

    Merge branch 'feature/introduce-junit-testing' of github.com:scroix/nodel into feature/introduce-junit-testing

    # Conflicts:
    #	nodel-framework/build.gradle

commit e386b21
Author: scroix <[email protected]>
Date:   Fri Apr 5 09:17:53 2024 +1100

    Introduce test cases to cover expected names of dynamically generated Actions and Events

    - These are in preparation for changes related to issue museumsvictoria#284

commit b67c120
Author: scroix <[email protected]>
Date:   Fri Apr 5 09:16:42 2024 +1100

    Add GitHubIssue annotation to mark up tests

commit 9d003b7
Author: scroix <[email protected]>
Date:   Fri Apr 5 09:15:51 2024 +1100

    minor: Remove public declaration from SimpleNameTest

commit 5ebcf19
Author: scroix <[email protected]>
Date:   Fri Apr 5 09:14:50 2024 +1100

    Add Mockito and Logback test dependencies

commit 7586d24
Author: scroix <[email protected]>
Date:   Thu Apr 4 17:42:25 2024 +1100

    Add first ever JUnit tests

    - Cover SimpleNameTest with a couple of test cases
    - Ensure they pass

commit e7b7e3e
Author: scroix <[email protected]>
Date:   Thu Apr 4 17:41:21 2024 +1100

    Add JUnit as a testing framework

    - Configure Gradle build to include JUnit dependencies

commit 9a23d63
Author: scroix <[email protected]>
Date:   Thu Apr 4 17:40:05 2024 +1100

    minor: ignore IntelliJ IDE files

commit 1440a78
Author: scroix <[email protected]>
Date:   Fri Apr 5 09:17:53 2024 +1100

    Introduce test cases to cover expected names of dynamically generated Actions and Events

    - These are in preparation for changes related to issue museumsvictoria#284

commit ac56791
Author: scroix <[email protected]>
Date:   Fri Apr 5 09:16:42 2024 +1100

    Add GitHubIssue annotation to mark up tests

commit 9e53135
Author: scroix <[email protected]>
Date:   Fri Apr 5 09:15:51 2024 +1100

    minor: Remove public declaration from SimpleNameTest

commit a37d107
Author: scroix <[email protected]>
Date:   Fri Apr 5 09:14:50 2024 +1100

    Add Mockito and Logback test dependencies

commit 6114356
Author: scroix <[email protected]>
Date:   Thu Apr 4 17:42:25 2024 +1100

    Add first ever JUnit tests

    - Cover SimpleNameTest with a couple of test cases
    - Ensure they pass

commit 9328669
Author: scroix <[email protected]>
Date:   Thu Apr 4 17:41:21 2024 +1100

    Add JUnit as a testing framework

    - Configure Gradle build to include JUnit dependencies

commit 36a59f3
Author: scroix <[email protected]>
Date:   Thu Apr 4 17:40:05 2024 +1100

    minor: ignore IntelliJ IDE files

commit de67ed4
Author: scroix <[email protected]>
Date:   Thu Apr 4 14:51:47 2024 +1100

    Rename branch in support of .jar generation

    - This tackles a tiny regression which saw us lose -dev- handled in the generated .jar filename
    - We also handle the odd case of building in a git branch which includes a forward slash

commit 138c477
Author: scroix <[email protected]>
Date:   Thu Apr 4 07:29:27 2024 +1100

    Stop targetting specific Gruntfile command

    - 'default' includes googlefonts build, but the 'build' command does not

commit 997b677
Author: scroix <[email protected]>
Date:   Sat Mar 30 13:46:36 2024 +1100

    Revert "Update gradle-wrapper.jar"

    This reverts commit 058a407.

commit 058a407
Author: scroix <[email protected]>
Date:   Sat Mar 30 13:46:17 2024 +1100

    Update gradle-wrapper.jar

commit d23abeb
Author: scroix <[email protected]>
Date:   Sat Mar 30 13:41:50 2024 +1100

    Switch to Gradle bin

commit 90c5066
Author: scroix <[email protected]>
Date:   Sat Mar 30 13:36:28 2024 +1100

    Update gradlew files

    - Using `gradle wrapper` command

commit 9018716
Author: scroix <[email protected]>
Date:   Sat Mar 30 13:24:58 2024 +1100

    Move project info variables to top-level build file

commit 0cfb6fd
Author: scroix <[email protected]>
Date:   Sat Mar 30 13:24:33 2024 +1100

    Revert to original devDependencies

commit 162d58d
Author: scroix <[email protected]>
Date:   Sat Mar 30 12:03:12 2024 +1100

    Revert node version to simplify grunt issue

commit 1b0b706
Author: scroix <[email protected]>
Date:   Sat Mar 30 08:13:58 2024 +1100

    Add a couple more optimisations

commit d65be71
Author: scroix <[email protected]>
Date:   Sat Mar 30 07:42:54 2024 +1100

    Move the feature to check for file changes into a class

commit 027a129
Author: scroix <[email protected]>
Date:   Sat Mar 30 07:18:03 2024 +1100

    Remove unneccesary dir check during Gradle webui tasks

commit 1a766c2
Author: scroix <[email protected]>
Date:   Sat Mar 30 07:17:27 2024 +1100

    Remove Gradle optimisation flags

commit 2fd735b
Author: Julien de-Sainte-Croix <[email protected]>
Date:   Fri Mar 29 22:26:53 2024 +1100

    Maybe this is working now

commit 820dba9
Author: Julien de-Sainte-Croix <[email protected]>
Date:   Fri Mar 29 21:57:48 2024 +1100

    Remove the grunt script from the package.json

commit 3e66086
Author: Julien de-Sainte-Croix <[email protected]>
Date:   Fri Mar 29 21:57:37 2024 +1100

    Further attempt to cache the grunt task

commit 3121adf
Author: Julien de-Sainte-Croix <[email protected]>
Date:   Fri Mar 29 20:51:49 2024 +1100

    Add hack for "cache" of grunt tasks

commit 48c0b59
Author: scroix <[email protected]>
Date:   Fri Mar 29 19:43:22 2024 +1100

    Attempt to cache grunt

commit 8a93e80
Author: scroix <[email protected]>
Date:   Fri Mar 29 19:42:47 2024 +1100

    Enable some speed-ups

commit d151cda
Author: scroix <[email protected]>
Date:   Fri Mar 29 16:29:48 2024 +1100

    Bump node-gradle plugin version to 7.0.2

commit 2c8f6f5
Author: scroix <[email protected]>
Date:   Fri Mar 29 16:29:22 2024 +1100

    Resolve minor warnings

commit 0fcc59e
Author: scroix <[email protected]>
Date:   Fri Mar 29 16:28:48 2024 +1100

    Replace deprecated jcenter

commit c10d6ef
Author: Julien de-Sainte-Croix <[email protected]>
Date:   Fri Mar 29 15:10:53 2024 +1100

    Bump Gradle version to 7.6.4

commit 9e05637
Author: Julien de-Sainte-Croix <[email protected]>
Date:   Mon Mar 18 21:13:46 2024 +1100

    Upgrade Gradle to 7.4 and Node.js to 16.x

    - Migrate build scripts to be compatible
    - Bump Node.js version to one which supports ARM/Silicon builds
    - Configure the node-gradle-plugin
scroix added a commit to scroix/nodel that referenced this issue May 3, 2024
commit 3c3bd3e
Author: scroix <[email protected]>
Date:   Wed Apr 24 20:38:13 2024 +1000

    Fix broken versioning of nodehost builds

    - museumsvictoria#314 (comment)

commit a2a27fd
Author: scroix <[email protected]>
Date:   Wed Apr 24 19:29:40 2024 +1000

    Apply Java 11 compile patch from @justparking

commit 1d9d4ad
Author: scroix <[email protected]>
Date:   Wed Apr 24 19:18:20 2024 +1000

    Revert "Revert to Java 8 compatible logback dependency"

    This reverts commit 1b9e15b.

commit 1b9e15b
Author: scroix <[email protected]>
Date:   Fri Apr 19 18:46:43 2024 +1000

    Revert to Java 8 compatible logback dependency

commit ca5bc00
Author: scroix <[email protected]>
Date:   Sat Apr 20 12:19:25 2024 +1000

    Revert "Merge branch 'feature/introduce-junit-testing' of github.com:scroix/nodel into feature/introduce-junit-testing"

    This reverts commit 50dfbcb, reversing
    changes made to b1a73ad.

commit 50dfbcb
Merge: b1a73ad d9830bc
Author: scroix <[email protected]>
Date:   Sat Apr 20 12:15:05 2024 +1000

    Merge branch 'feature/introduce-junit-testing' of github.com:scroix/nodel into feature/introduce-junit-testing

    # Conflicts:
    #	nodel-framework/build.gradle
    #	nodel-framework/src/test/java/org/nodel/SimpleNameTest.java

commit b1a73ad
Author: scroix <[email protected]>
Date:   Thu Apr 4 17:42:25 2024 +1100

    Add first ever JUnit tests

    - Cover SimpleNameTest with a couple of test cases
    - Ensure they pass

commit 9a0ebd2
Author: scroix <[email protected]>
Date:   Thu Apr 4 17:41:21 2024 +1100

    Add JUnit as a testing framework

    - Configure Gradle build to include JUnit dependencies

commit 1198db3
Author: scroix <[email protected]>
Date:   Fri Apr 5 09:17:53 2024 +1100

    Introduce test cases to cover expected names of dynamically generated Actions and Events

    - These are in preparation for changes related to issue museumsvictoria#284

commit da01834
Author: scroix <[email protected]>
Date:   Fri Apr 5 09:16:42 2024 +1100

    Add GitHubIssue annotation to mark up tests

commit a1c0e13
Author: scroix <[email protected]>
Date:   Fri Apr 5 09:15:51 2024 +1100

    minor: Remove public declaration from SimpleNameTest

commit c04baf2
Author: scroix <[email protected]>
Date:   Fri Apr 5 09:14:50 2024 +1100

    Add Mockito and Logback test dependencies

commit 2daa92b
Author: scroix <[email protected]>
Date:   Thu Apr 4 17:42:25 2024 +1100

    Add first ever JUnit tests

    - Cover SimpleNameTest with a couple of test cases
    - Ensure they pass

commit 14b7033
Author: scroix <[email protected]>
Date:   Thu Apr 4 17:41:21 2024 +1100

    Add JUnit as a testing framework

    - Configure Gradle build to include JUnit dependencies

commit d9830bc
Author: scroix <[email protected]>
Date:   Fri Apr 19 18:46:43 2024 +1000

    Revert to Java 8 compatible logback dependency

commit e74f409
Author: scroix <[email protected]>
Date:   Sat Apr 6 16:11:43 2024 +1100

    Revert to original parent build file

commit 128dbe2
Author: scroix <[email protected]>
Date:   Sat Apr 6 16:10:18 2024 +1100

    Re-add Gradle job for running tests

commit 6a0ed30
Author: scroix <[email protected]>
Date:   Sat Apr 6 16:08:20 2024 +1100

    Revert "minor: ignore IntelliJ IDE files"

    This reverts commit 9a23d63.

commit 08e99fe
Author: scroix <[email protected]>
Date:   Sat Apr 6 16:04:59 2024 +1100

    Manually 'rebase' in preparation for PR

commit 2ff6dda
Merge: e386b21 1440a78
Author: Julien de-Sainte-Croix <[email protected]>
Date:   Sat Apr 6 15:21:28 2024 +1100

    Merge branch 'feature/introduce-junit-testing' of github.com:scroix/nodel into feature/introduce-junit-testing

    # Conflicts:
    #	nodel-framework/build.gradle

commit e386b21
Author: scroix <[email protected]>
Date:   Fri Apr 5 09:17:53 2024 +1100

    Introduce test cases to cover expected names of dynamically generated Actions and Events

    - These are in preparation for changes related to issue museumsvictoria#284

commit b67c120
Author: scroix <[email protected]>
Date:   Fri Apr 5 09:16:42 2024 +1100

    Add GitHubIssue annotation to mark up tests

commit 9d003b7
Author: scroix <[email protected]>
Date:   Fri Apr 5 09:15:51 2024 +1100

    minor: Remove public declaration from SimpleNameTest

commit 5ebcf19
Author: scroix <[email protected]>
Date:   Fri Apr 5 09:14:50 2024 +1100

    Add Mockito and Logback test dependencies

commit 7586d24
Author: scroix <[email protected]>
Date:   Thu Apr 4 17:42:25 2024 +1100

    Add first ever JUnit tests

    - Cover SimpleNameTest with a couple of test cases
    - Ensure they pass

commit e7b7e3e
Author: scroix <[email protected]>
Date:   Thu Apr 4 17:41:21 2024 +1100

    Add JUnit as a testing framework

    - Configure Gradle build to include JUnit dependencies

commit 9a23d63
Author: scroix <[email protected]>
Date:   Thu Apr 4 17:40:05 2024 +1100

    minor: ignore IntelliJ IDE files

commit 1440a78
Author: scroix <[email protected]>
Date:   Fri Apr 5 09:17:53 2024 +1100

    Introduce test cases to cover expected names of dynamically generated Actions and Events

    - These are in preparation for changes related to issue museumsvictoria#284

commit ac56791
Author: scroix <[email protected]>
Date:   Fri Apr 5 09:16:42 2024 +1100

    Add GitHubIssue annotation to mark up tests

commit 9e53135
Author: scroix <[email protected]>
Date:   Fri Apr 5 09:15:51 2024 +1100

    minor: Remove public declaration from SimpleNameTest

commit a37d107
Author: scroix <[email protected]>
Date:   Fri Apr 5 09:14:50 2024 +1100

    Add Mockito and Logback test dependencies

commit 6114356
Author: scroix <[email protected]>
Date:   Thu Apr 4 17:42:25 2024 +1100

    Add first ever JUnit tests

    - Cover SimpleNameTest with a couple of test cases
    - Ensure they pass

commit 9328669
Author: scroix <[email protected]>
Date:   Thu Apr 4 17:41:21 2024 +1100

    Add JUnit as a testing framework

    - Configure Gradle build to include JUnit dependencies

commit 36a59f3
Author: scroix <[email protected]>
Date:   Thu Apr 4 17:40:05 2024 +1100

    minor: ignore IntelliJ IDE files

commit de67ed4
Author: scroix <[email protected]>
Date:   Thu Apr 4 14:51:47 2024 +1100

    Rename branch in support of .jar generation

    - This tackles a tiny regression which saw us lose -dev- handled in the generated .jar filename
    - We also handle the odd case of building in a git branch which includes a forward slash

commit 138c477
Author: scroix <[email protected]>
Date:   Thu Apr 4 07:29:27 2024 +1100

    Stop targetting specific Gruntfile command

    - 'default' includes googlefonts build, but the 'build' command does not

commit 997b677
Author: scroix <[email protected]>
Date:   Sat Mar 30 13:46:36 2024 +1100

    Revert "Update gradle-wrapper.jar"

    This reverts commit 058a407.

commit 058a407
Author: scroix <[email protected]>
Date:   Sat Mar 30 13:46:17 2024 +1100

    Update gradle-wrapper.jar

commit d23abeb
Author: scroix <[email protected]>
Date:   Sat Mar 30 13:41:50 2024 +1100

    Switch to Gradle bin

commit 90c5066
Author: scroix <[email protected]>
Date:   Sat Mar 30 13:36:28 2024 +1100

    Update gradlew files

    - Using `gradle wrapper` command

commit 9018716
Author: scroix <[email protected]>
Date:   Sat Mar 30 13:24:58 2024 +1100

    Move project info variables to top-level build file

commit 0cfb6fd
Author: scroix <[email protected]>
Date:   Sat Mar 30 13:24:33 2024 +1100

    Revert to original devDependencies

commit 162d58d
Author: scroix <[email protected]>
Date:   Sat Mar 30 12:03:12 2024 +1100

    Revert node version to simplify grunt issue

commit 1b0b706
Author: scroix <[email protected]>
Date:   Sat Mar 30 08:13:58 2024 +1100

    Add a couple more optimisations

commit d65be71
Author: scroix <[email protected]>
Date:   Sat Mar 30 07:42:54 2024 +1100

    Move the feature to check for file changes into a class

commit 027a129
Author: scroix <[email protected]>
Date:   Sat Mar 30 07:18:03 2024 +1100

    Remove unneccesary dir check during Gradle webui tasks

commit 1a766c2
Author: scroix <[email protected]>
Date:   Sat Mar 30 07:17:27 2024 +1100

    Remove Gradle optimisation flags

commit 2fd735b
Author: Julien de-Sainte-Croix <[email protected]>
Date:   Fri Mar 29 22:26:53 2024 +1100

    Maybe this is working now

commit 820dba9
Author: Julien de-Sainte-Croix <[email protected]>
Date:   Fri Mar 29 21:57:48 2024 +1100

    Remove the grunt script from the package.json

commit 3e66086
Author: Julien de-Sainte-Croix <[email protected]>
Date:   Fri Mar 29 21:57:37 2024 +1100

    Further attempt to cache the grunt task

commit 3121adf
Author: Julien de-Sainte-Croix <[email protected]>
Date:   Fri Mar 29 20:51:49 2024 +1100

    Add hack for "cache" of grunt tasks

commit 48c0b59
Author: scroix <[email protected]>
Date:   Fri Mar 29 19:43:22 2024 +1100

    Attempt to cache grunt

commit 8a93e80
Author: scroix <[email protected]>
Date:   Fri Mar 29 19:42:47 2024 +1100

    Enable some speed-ups

commit d151cda
Author: scroix <[email protected]>
Date:   Fri Mar 29 16:29:48 2024 +1100

    Bump node-gradle plugin version to 7.0.2

commit 2c8f6f5
Author: scroix <[email protected]>
Date:   Fri Mar 29 16:29:22 2024 +1100

    Resolve minor warnings

commit 0fcc59e
Author: scroix <[email protected]>
Date:   Fri Mar 29 16:28:48 2024 +1100

    Replace deprecated jcenter

commit c10d6ef
Author: Julien de-Sainte-Croix <[email protected]>
Date:   Fri Mar 29 15:10:53 2024 +1100

    Bump Gradle version to 7.6.4

commit 9e05637
Author: Julien de-Sainte-Croix <[email protected]>
Date:   Mon Mar 18 21:13:46 2024 +1100

    Upgrade Gradle to 7.4 and Node.js to 16.x

    - Migrate build scripts to be compatible
    - Bump Node.js version to one which supports ARM/Silicon builds
    - Configure the node-gradle-plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants