Fixes

- fix opening the pipes
- fix build for amd cpu's

Author: marcelveldt

.github/workflows/build.yml

@@ -38,16 +38,32 @@ jobs:
           if [ "${{ matrix.os-arch }}" = "aarch64" ]; then
             export CC=aarch64-linux-gnu-gcc
             export CXX=aarch64-linux-gnu-g++
+            # Ensure standard libraries are statically linked
+            export LDFLAGS="-static-libgcc -static-libstdc++"
           else
             export CC=x86_64-linux-gnu-gcc
             export CXX=x86_64-linux-gnu-g++
-            export CFLAGS="-march=x86-64"
-            export CXXFLAGS="-march=x86-64"
+            # Use baseline x86-64 with generic tuning for maximum compatibility
+            # -static-libgcc -static-libstdc++ ensure stdlib is statically linked
+            export CFLAGS="-march=x86-64 -mtune=generic"
+            export CXXFLAGS="-march=x86-64 -mtune=generic"
+            export LDFLAGS="-static-libgcc -static-libstdc++"
           fi
           make HOST=linux PLATFORM=${{ matrix.os-arch }} STATIC=1 -j$(nproc)
           chmod +x bin/cliraop-linux-${{ matrix.os-arch }}
           cp bin/cliraop-linux-${{ matrix.os-arch }} release/
 
+      - name: Verify binary
+        run: |
+          echo "Binary info:"
+          file bin/cliraop-linux-${{ matrix.os-arch }}
+          echo ""
+          echo "Dynamic dependencies:"
+          ldd bin/cliraop-linux-${{ matrix.os-arch }} || echo "Static binary (no dependencies)"
+          echo ""
+          echo "Size:"
+          ls -lh bin/cliraop-linux-${{ matrix.os-arch }}
+
       - name: Upload artifacts
         uses: actions/upload-artifact@v4
         with:

src/cliraop.c

@@ -148,7 +148,19 @@ static void close_platform()
 /*----------------------------------------------------------------------------*/
 static void *CmdPipeReaderThread(void *args)
 {
-	cmdPipeFd = open(cmdPipeName, O_RDONLY);
+	// Open with O_NONBLOCK to avoid blocking if no writer is present
+	cmdPipeFd = open(cmdPipeName, O_RDONLY | O_NONBLOCK);
+	if (cmdPipeFd == -1)
+	{
+		LOG_ERROR("Failed to open command pipe: %s", cmdPipeName);
+		return NULL;
+	}
+
+	// Set back to blocking mode after opening
+	int file_flags = fcntl(cmdPipeFd, F_GETFL);
+	fcntl(cmdPipeFd, F_SETFL, file_flags & ~O_NONBLOCK);
+	LOG_INFO("Command pipe opened successfully");
+
 	struct
 	{
 		char *title;
@@ -164,7 +176,9 @@ static void *CmdPipeReaderThread(void *args)
 		if (!glMainRunning)
 			break;
 
-		if (read(cmdPipeFd, cmdPipeBuf, 512) > 0)
+		ssize_t bytes_read = read(cmdPipeFd, cmdPipeBuf, 512);
+
+		if (bytes_read > 0)
 		{
 			// read lines
 			char *save_ptr1, *save_ptr2;
@@ -296,8 +310,30 @@ static void *CmdPipeReaderThread(void *args)
 			// clear cmdPipeBuf
 			memset(cmdPipeBuf, 0, sizeof cmdPipeBuf);
 		}
+		else if (bytes_read == 0)
+		{
+			// EOF - writer closed the pipe, reopen to wait for next writer
+			LOG_DEBUG("Command pipe writer disconnected, waiting for reconnection...");
+			close(cmdPipeFd);
+
+			// Reopen with O_NONBLOCK to avoid blocking
+			cmdPipeFd = open(cmdPipeName, O_RDONLY | O_NONBLOCK);
+			if (cmdPipeFd == -1)
+			{
+				LOG_ERROR("Failed to reopen command pipe: %s", cmdPipeName);
+				break;
+			}
+
+			// Set back to blocking mode for reads
+			int file_flags = fcntl(cmdPipeFd, F_GETFL);
+			fcntl(cmdPipeFd, F_SETFL, file_flags & ~O_NONBLOCK);
+
+			// Small delay before trying to read again
+			usleep(100 * 1000); // 100ms
+		}
 		else
 		{
+			// Error on read, sleep and retry
 			usleep(250 * 1000);
 		}
 	}
@@ -670,15 +706,13 @@ int main(int argc, char *argv[])
 
 	buf = malloc(DEFAULT_FRAMES_PER_CHUNK * 4);
 	uint32_t KeepAlive = 0;
+	bool got_eof = false;
 
 	// keep reading audio from stdin until exit/EOF
-	while (n || raopcl_is_playing(raopcl))
+	while (status != STOPPED && (!got_eof || raopcl_is_playing(raopcl)))
 	{
 		uint64_t playtime, now;
 
-		if (status == STOPPED)
-			break;
-
 		now = raopcl_get_ntp(NULL);
 
 		// execute every second
@@ -701,11 +735,30 @@ int main(int argc, char *argv[])
 		{
 			n = read(infile, buf, DEFAULT_FRAMES_PER_CHUNK * 4);
 
-			if (!n)
+			if (n < 0)
 			{
-				// EOF or no writer on FIFO yet - sleep to avoid busy-waiting
-				usleep(10000); // 10ms
-				continue;
+				// Error on read
+				LOG_ERROR("Error reading from audio source");
+				break;
+			}
+			else if (n == 0)
+			{
+				// EOF or no writer on FIFO yet
+				// Check if this is a regular file (true EOF) or FIFO (no writer yet)
+				struct stat st;
+				if (fstat(infile, &st) == 0 && S_ISFIFO(st.st_mode))
+				{
+					// It's a FIFO - no writer yet, keep waiting
+					usleep(10000); // 10ms
+					continue;
+				}
+				else
+				{
+					// Regular file EOF - mark as done and drain the buffer
+					LOG_INFO("End of audio file reached, draining buffer...");
+					got_eof = true;
+					continue;
+				}
 			}
 
 			raopcl_send_chunk(raopcl, buf, n / 4, &playtime);