refactor: improve get_following_activities and fix throttler settings

- Call get_track directly instead of get_provider_item for simplicity
- Remove unnecessary semaphore (throttler already handles rate limiting)
- Fix throttler settings: rate_limit=5, period=1 (5 req/sec) for high priority
- Fix low priority throttler: period=1 for consistency

Author: Shi-553

music_assistant/providers/nicovideo/services/manager.py

@@ -47,9 +47,9 @@ def __init__(self, provider: MusicProvider, nicovideo_config: NicovideoConfig) -
         self.mass = provider.mass
         self.reset_niconico_py_client()
 
-        self.niconico_api_throttler = ThrottlerManager(rate_limit=1, period=0)
+        self.niconico_api_throttler = ThrottlerManager(rate_limit=5, period=1)
         # Low priority throttler for background tag updates (slower rate)
-        self.niconico_api_throttler_low_priority = ThrottlerManager(rate_limit=1, period=0.3)
+        self.niconico_api_throttler_low_priority = ThrottlerManager(rate_limit=1, period=1)
 
         self.logger = provider.logger
 

music_assistant/providers/nicovideo/services/user.py

@@ -5,8 +5,6 @@
 import asyncio
 from typing import TYPE_CHECKING
 
-from music_assistant_models.errors import MediaNotFoundError
-
 from music_assistant.providers.nicovideo.constants import SENSITIVE_CONTENTS
 from music_assistant.providers.nicovideo.services.base import NicovideoBaseService
 
@@ -169,21 +167,7 @@ async def get_following_activities(self, limit: int = 50) -> list[Track]:
                 if len(video_ids) >= limit:
                     break
 
-        # Process tracks with limited concurrency to avoid DB overload
-
-        semaphore = asyncio.Semaphore(5)  # Limit to 5 concurrent requests
-
-        async def get_track_with_limit(video_id: str) -> Track | None:
-            async with semaphore:
-                try:
-                    return await self.service_manager.provider.mass.music.tracks.get_provider_item(
-                        video_id, self.service_manager.provider.instance_id
-                    )
-                except MediaNotFoundError:
-                    return None
-
-        # Execute with limited concurrency
-        track_tasks = [get_track_with_limit(video_id) for video_id in video_ids]
+        track_tasks = [self.service_manager.provider.get_track(video_id) for video_id in video_ids]
         tracks_results = await asyncio.gather(*track_tasks, return_exceptions=True)
 
         # Filter successful results