Skip to content

Commit 717e714

Browse files
authored
fix: prevent some NaN scenarios (#281)
Co-authored-by: Juan <[email protected]>
1 parent 700eadb commit 717e714

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

public/inclination/inclination.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,16 +16,19 @@ RealtimeIRL.forPullKey(key).addListener(
1616
// We have new gps points. Let's calculate the delta distance using previously saved gps points (IN METERS)
1717
delta = distanceInKmBetweenEarthCoordinates(gps.new.latitude, gps.new.longitude, gps.old.latitude, gps.old.longitude) * 1000;
1818

19-
// Now calculate the slope percentage, based on altitude change and distance travelled
20-
gps.new.inclination = ((gps.new.altitude - gps.old.altitude) / delta * 100);
19+
if (delta !== 0) {
20+
gps.new.inclination = ((gps.new.altitude - gps.old.altitude) / delta * 100);
21+
} else {
22+
gps.new.inclination = 0;
23+
}
2124

2225
// Ease-in inclination, no sudden jumps
2326
inclination = (gps.new.inclination + gps.old.inclination) / 2;
2427

2528
gps.old.inclination = gps.new.inclination;
2629

2730
// "Fix" errors
28-
if ((inclination > 40) || (inclination < -40)){
31+
if ((inclination > 40) || (inclination < -40) || isNaN(inclination)){
2932
inclination = 0.0;
3033
}
3134

0 commit comments

Comments
 (0)