Feature Request: Space bar play/pause after entering full screen

[dylanjha]

Is there an existing issue for this?

• I have searched the existing issues

Which Mux Elements/Packages does this apply to? Select all that apply

mux-player

Description

1. Enter full screen
2. Full-screen button still has focus
3. Clicking space bar exits full screen

Expected Behavior

What I actually want is the space bar to play/pause

If the player itself is focused, the space bar will play/pause, but because the fullscreen button is focused the space bar will exit full screen.

Is this intentional? Any way around this? Would it be weird if after entering full screen, the focus moved to the player instead of staying on the full screen button?

[danijossnet]

Agreed - I think the space bar should always be play/pause. At the very least, after going full-screen, the focus should move to the player. This is near universal behaviour for video players. I would expect to click fullscreen, then hit space. The escape key correctly cancels fullscreen in this situation.

[Pintorado]

Hi! You are right, after entering full-screen the focus should be on the player and not in the full-screen button. I will take a look at this soon

[cjpillsbury]

Hey folks! I definitely get the intuition here. My main worry is the impact any solution here would have on accessibility and folks using things like screen readers and keyboard or similar navigation. Would adding a hotkey to enter/exit fullscreen from the player level be a sufficient compromise here?

[cjpillsbury]

We'll do some "lay of the land" exploration here. It looks like Youtube, for example, will handle this case when using mouse click interactions but is actually the "worst of both worlds" when using keyboard navigation and interaction - not only does it not toggle play/pause, it also doesn't toggle fullscreen. I also just want to make sure that we're doing something reasonable with respect to A11Y even if the industry standard doesn't do that (obviously this requires some consideration of potential tradeoffs and compromises).