Skip to content
This repository was archived by the owner on Feb 27, 2023. It is now read-only.
This repository was archived by the owner on Feb 27, 2023. It is now read-only.

Incorrect redshift for models. #24

@djperrefort

Description

@djperrefort

The fluxes we are using to define each custom model are simulated at a distance of 1 kpc away. However, sncosmo asserts a default redshift of 0 for each instantiated Model class. Technically this isn't a big deal because 1 kpc is a pretty small redshift:

>>> from astropy import units as u
>>> from astropy.cosmology import WMAP9
>>> from astropy.coordinates import Distance
>>>
>>> d = Distance(value=1, unit=u.kpc)
>>> d.compute_z(WMAP9)
2.3120594343144655e-07

However, I would still prefer us porting the model correctly.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions