Refactor `_synthetic_photometry.py` so that each for loop calls a function

[wmwv]

In

nir-comparison/analysis/spectra_chisq/_synthetic_photometry.py

there are a few for loops. I would recommend that the body of each of these for loops be defined as a function. That makes the bodies of these loops testable.