[IMP] hr_timesheet_sheet_activity: black, isort, prettier

Author: ilyasProgrammer

hr_timesheet_sheet_activity/__manifest__.py

@@ -3,25 +3,22 @@
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).
 
 {
-    'name': 'HR Timesheet Sheet Activities',
-    'version': '12.0.1.0.0',
-    'category': 'Human Resources',
-    'website': 'https://github.com/OCA/timesheet',
-    'author':
-        'CorporateHub, '
-        'Odoo Community Association (OCA)',
-    'license': 'AGPL-3',
-    'installable': True,
-    'application': False,
-    'summary': (
-        'Automatic activities related to submission and review of timesheet'
-        ' sheets'
+    "name": "HR Timesheet Sheet Activities",
+    "version": "12.0.1.0.0",
+    "category": "Human Resources",
+    "website": "https://github.com/OCA/timesheet",
+    "author": "CorporateHub, " "Odoo Community Association (OCA)",
+    "license": "AGPL-3",
+    "installable": True,
+    "application": False,
+    "summary": (
+        "Automatic activities related to submission and review of timesheet" " sheets"
     ),
-    'depends': [
-        'hr_timesheet_sheet',
+    "depends": [
+        "hr_timesheet_sheet",
     ],
-    'data': [
-        'data/hr_timesheet_sheet_activity_data.xml',
-        'views/mail_activity.xml',
+    "data": [
+        "data/hr_timesheet_sheet_activity_data.xml",
+        "views/mail_activity.xml",
     ],
 }

hr_timesheet_sheet_activity/data/hr_timesheet_sheet_activity_data.xml

@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8" ?>
 <!--
     Copyright 2020 Brainbean Apps (https://brainbeanapps.com)
     License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
@@ -10,19 +10,19 @@
     <record id="activity_sheet_submission" model="mail.activity.type">
         <field name="name">Timesheet Sheet Submission</field>
         <field name="icon">fa-calendar-check-o</field>
-        <field name="res_model_id" ref="hr_timesheet_sheet.model_hr_timesheet_sheet"/>
+        <field name="res_model_id" ref="hr_timesheet_sheet.model_hr_timesheet_sheet" />
     </record>
 
     <record id="activity_sheet_review" model="mail.activity.type">
         <field name="name">Timesheet Sheet Review</field>
         <field name="icon">fa-calendar-check-o</field>
-        <field name="res_model_id" ref="hr_timesheet_sheet.model_hr_timesheet_sheet"/>
+        <field name="res_model_id" ref="hr_timesheet_sheet.model_hr_timesheet_sheet" />
     </record>
 
     <record id="activity_sheet_resubmission" model="mail.activity.type">
         <field name="name">Timesheet Sheet Re-submission</field>
         <field name="icon">fa-calendar-check-o</field>
-        <field name="res_model_id" ref="hr_timesheet_sheet.model_hr_timesheet_sheet"/>
+        <field name="res_model_id" ref="hr_timesheet_sheet.model_hr_timesheet_sheet" />
     </record>
 
 </odoo>

hr_timesheet_sheet_activity/models/hr_timesheet_sheet.py

@@ -2,41 +2,44 @@
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
 from datetime import datetime, time
+
 from dateutil.relativedelta import relativedelta
 from dateutil.rrule import MONTHLY, WEEKLY
-from pytz import timezone, UTC
+from pytz import UTC, timezone
 
 from odoo import api, fields, models
 
 
 class HrTimesheetSheet(models.Model):
-    _inherit = 'hr_timesheet.sheet'
+    _inherit = "hr_timesheet.sheet"
 
     def _get_subscribers(self):
-        """ Reviewers are going to be notified using activities """
+        """Reviewers are going to be notified using activities"""
         res = super()._get_subscribers()
-        res = res - self._get_possible_reviewers().mapped('partner_id')
+        res = res - self._get_possible_reviewers().mapped("partner_id")
         return res
 
     @api.multi
     def write(self, vals):
         res = super().write(vals)
 
-        for sheet in self.filtered(lambda sheet: sheet.state == 'draft'):
+        for sheet in self.filtered(lambda sheet: sheet.state == "draft"):
             # NOTE: user_id is written manually instead of using new_user_id
             # in order to update only activities with different user_id
             activities = sheet.activity_reschedule(
-                ['hr_timesheet_sheet_activity.activity_sheet_resubmission'],
+                ["hr_timesheet_sheet_activity.activity_sheet_resubmission"],
             )
             for activity in activities:
                 if activity.user_id == sheet.user_id:
                     continue
                 if activity.user_id != self.env.user:
                     # NOTE: Only assigned user can update the activity
                     activity = activity.sudo()
-                activity.write({
-                    'user_id': sheet.user_id.id,
-                })
+                activity.write(
+                    {
+                        "user_id": sheet.user_id.id,
+                    }
+                )
             if activities:
                 continue
 
@@ -45,20 +48,24 @@ def write(self, vals):
             # NOTE: Instead of updating activities using activity_reschedule,
             # manually update only needed fields
             activities = sheet.activity_reschedule(
-                ['hr_timesheet_sheet_activity.activity_sheet_submission'],
+                ["hr_timesheet_sheet_activity.activity_sheet_submission"],
             )
             for activity in activities:
                 values = {}
                 if activity.user_id != sheet.user_id:
-                    values.update({
-                        'user_id': sheet.user_id.id,
-                    })
+                    values.update(
+                        {
+                            "user_id": sheet.user_id.id,
+                        }
+                    )
                 if activity.date_deadline != deadline:
-                    values.update({
-                        # NOTE: user_id is set to trigger a notification
-                        'user_id': sheet.user_id.id,
-                        'date_deadline': deadline,
-                    })
+                    values.update(
+                        {
+                            # NOTE: user_id is set to trigger a notification
+                            "user_id": sheet.user_id.id,
+                            "date_deadline": deadline,
+                        }
+                    )
                 if not values:
                     continue
 
@@ -76,7 +83,7 @@ def write(self, vals):
                 continue
 
             sheet.activity_schedule(
-                'hr_timesheet_sheet_activity.activity_sheet_submission',
+                "hr_timesheet_sheet_activity.activity_sheet_submission",
                 date_deadline=deadline,
                 user_id=sheet.user_id.id,
             )
@@ -87,7 +94,7 @@ def write(self, vals):
     def action_timesheet_draft(self):
         for sheet in self:
             sheet.activity_schedule(
-                'hr_timesheet_sheet_activity.activity_sheet_resubmission',
+                "hr_timesheet_sheet_activity.activity_sheet_resubmission",
                 date_deadline=sheet._activity_sheet_resubmission_deadline(),
                 user_id=sheet.user_id.id,
             )
@@ -100,10 +107,12 @@ def action_timesheet_confirm(self):
 
         # NOTE: activity_reschedule is used instead of activity_feedback
         # to accomodate non-assigned-user completion
-        activities = self.activity_reschedule([
-            'hr_timesheet_sheet_activity.activity_sheet_submission',
-            'hr_timesheet_sheet_activity.activity_sheet_resubmission',
-        ])
+        activities = self.activity_reschedule(
+            [
+                "hr_timesheet_sheet_activity.activity_sheet_submission",
+                "hr_timesheet_sheet_activity.activity_sheet_resubmission",
+            ]
+        )
         for activity in activities:
             if activity.user_id != self.env.user:
                 # NOTE: Only assigned user can update the activity
@@ -112,11 +121,9 @@ def action_timesheet_confirm(self):
 
         for sheet in self:
             for reviewer in sheet._get_possible_reviewers():
-                deadline = sheet._activity_sheet_review_deadline(
-                    reviewer
-                )
+                deadline = sheet._activity_sheet_review_deadline(reviewer)
                 sheet.activity_schedule(
-                    'hr_timesheet_sheet_activity.activity_sheet_review',
+                    "hr_timesheet_sheet_activity.activity_sheet_review",
                     date_deadline=deadline,
                     user_id=reviewer.id,
                 )
@@ -127,9 +134,11 @@ def action_timesheet_done(self):
 
         # NOTE: activity_reschedule is used instead of activity_feedback
         # to accomodate non-assigned-user completion
-        activities = self.activity_reschedule([
-            'hr_timesheet_sheet_activity.activity_sheet_review',
-        ])
+        activities = self.activity_reschedule(
+            [
+                "hr_timesheet_sheet_activity.activity_sheet_review",
+            ]
+        )
         for activity in activities:
             if activity.user_id != self.env.user:
                 # NOTE: Only assigned user can update the activity
@@ -140,7 +149,7 @@ def action_timesheet_done(self):
     def action_timesheet_refuse(self):
         for sheet in self:
             sheet.activity_schedule(
-                'hr_timesheet_sheet_activity.activity_sheet_resubmission',
+                "hr_timesheet_sheet_activity.activity_sheet_resubmission",
                 date_deadline=sheet._activity_sheet_resubmission_deadline(),
                 user_id=sheet.user_id.id,
             )
@@ -149,9 +158,11 @@ def action_timesheet_refuse(self):
 
         # NOTE: activity_reschedule is used instead of activity_feedback
         # to accomodate non-assigned-user completion
-        activities = self.activity_reschedule([
-            'hr_timesheet_sheet_activity.activity_sheet_review',
-        ])
+        activities = self.activity_reschedule(
+            [
+                "hr_timesheet_sheet_activity.activity_sheet_review",
+            ]
+        )
         for activity in activities:
             if activity.user_id != self.env.user:
                 # NOTE: Only assigned user can update the activity
@@ -160,15 +171,16 @@ def action_timesheet_refuse(self):
 
     @api.multi
     def _activity_sheet_submission_deadline(self):
-        """ Hook for extensions """
+        """Hook for extensions"""
         self.ensure_one()
 
-        employee_timezone = timezone(self.employee_id.tz or 'UTC')
+        employee_timezone = timezone(self.employee_id.tz or "UTC")
         employee_today = self.env.context.get(
-            'hr_timesheet_sheet_activity_today',
-            fields.Datetime.now().replace(tzinfo=UTC).astimezone(
-                employee_timezone
-            ).date()
+            "hr_timesheet_sheet_activity_today",
+            fields.Datetime.now()
+            .replace(tzinfo=UTC)
+            .astimezone(employee_timezone)
+            .date(),
         )
 
         # Get last workday of employee or last day of period (in user tz)
@@ -177,77 +189,69 @@ def _activity_sheet_submission_deadline(self):
             time.min,
         ).replace(tzinfo=employee_timezone)
         datetime_end = datetime.combine(
-            max(self.date_end, employee_today),
-            time.max
+            max(self.date_end, employee_today), time.max
         ).replace(tzinfo=employee_timezone)
         worktimes = self.employee_id.list_work_time_per_day(
             datetime_start,
             datetime_end,
         )
-        worktimes = list(filter(
-            lambda worktime: worktime[1] > 0,
-            worktimes
-        ))
+        worktimes = list(filter(lambda worktime: worktime[1] > 0, worktimes))
         if worktimes:
             return worktimes[-1][0]  # Last workday of period
         return datetime_end.date()
 
     @api.multi
     def _activity_sheet_resubmission_deadline(self):
-        """ Hook for extensions """
+        """Hook for extensions"""
         self.ensure_one()
         return None
 
     @api.multi
     def _activity_sheet_review_deadline(self, reviewer):
-        """ Hook for extensions """
+        """Hook for extensions"""
         self.ensure_one()
 
-        employee_timezone = timezone(self.employee_id.tz or 'UTC')
+        employee_timezone = timezone(self.employee_id.tz or "UTC")
         employee_today = self.env.context.get(
-            'hr_timesheet_sheet_activity_today',
-            fields.Datetime.now().replace(tzinfo=UTC).astimezone(
-                employee_timezone
-            ).date()
-        )
-        deadline = max(
-            self.date_end + relativedelta(days=1),
-            employee_today
+            "hr_timesheet_sheet_activity_today",
+            fields.Datetime.now()
+            .replace(tzinfo=UTC)
+            .astimezone(employee_timezone)
+            .date(),
         )
+        deadline = max(self.date_end + relativedelta(days=1), employee_today)
 
-        reviewer_employee = self.env['hr.employee'].with_context(
-            active_test=False,
-        ).search(
-            [('user_id', '=', reviewer.id)],
-            limit=1,
+        reviewer_employee = (
+            self.env["hr.employee"]
+            .with_context(
+                active_test=False,
+            )
+            .search(
+                [("user_id", "=", reviewer.id)],
+                limit=1,
+            )
         )
         if not reviewer_employee:
             return deadline
 
         worktimes = reviewer_employee.list_work_time_per_day(
+            datetime.combine(deadline, time.min).replace(tzinfo=employee_timezone),
             datetime.combine(
-                deadline,
-                time.min
-            ).replace(tzinfo=employee_timezone),
-            datetime.combine(
-                deadline + self._activity_sheet_review_max_period(),
-                time.max
+                deadline + self._activity_sheet_review_max_period(), time.max
             ).replace(tzinfo=employee_timezone),
         )
-        worktimes = list(filter(
-            lambda worktime: worktime[1] > 0,
-            worktimes
-        ))
+        worktimes = list(filter(lambda worktime: worktime[1] > 0, worktimes))
         if worktimes:
             return worktimes[0][0]  # First workday of period
-        return datetime.combine(deadline, time.max).replace(
-            tzinfo=employee_timezone
-        ).astimezone(
-            timezone(reviewer_employee.tz or 'UTC')
-        ).date()
+        return (
+            datetime.combine(deadline, time.max)
+            .replace(tzinfo=employee_timezone)
+            .astimezone(timezone(reviewer_employee.tz or "UTC"))
+            .date()
+        )
 
     def _activity_sheet_review_max_period(self):
-        """ Hook for extensions """
+        """Hook for extensions"""
         self.ensure_one()
         r = self.company_id.sheet_range or WEEKLY
         if r == WEEKLY: