Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade password policy #1858

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

arthurpar06
Copy link
Contributor

No description provided.

Copy link

gitguardian bot commented Jul 26, 2024

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - Generic Password a2728db tests/RegistrationTest.php View secret
- - Generic Password 993c932 tests/RegistrationTest.php View secret
- - Generic Password 993c932 tests/RegistrationTest.php View secret
- - Generic Password a2728db tests/RegistrationTest.php View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@FatihKoz
Copy link
Contributor

Come on, minimum 8 chars, mixed with numbers, upper-lower case ? 😿

Will you add a forced password change every week too, like we are logging in to a super secret service with tons of sensitive data, credit card transactions, bank accounts, missile passwords etc. ? 😆

Jokes aside, is this really necessary ?

@arthurpar06
Copy link
Contributor Author

This follows the NIST recommendations for passwords, which is important in my opinion.

I hope the NASA's passwords are longer than 8 characters 😄. More seriously, even if we don’t store highly critical data, we still have people’s personal information, and from my perspective, they deserve to have their data at least minimally secure. Additionally, it eliminates weak passwords like "password" or "admin" and encourages users to get into the habit of using stronger passwords.

I feel like this level of security is a good compromise between not being too annoying for the user and still providing some protection. We don't require symbols or very long passwords, just a number, an uppercase, and a lowercase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants