Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent code/docs for host check_period #84

Closed
julianbrost opened this issue Aug 4, 2014 · 2 comments
Closed

Inconsistent code/docs for host check_period #84

julianbrost opened this issue Aug 4, 2014 · 2 comments

Comments

@julianbrost
Copy link
Contributor

The docs on host objects list check_period as a required attribute but Naemon starts fine (even without warnings) if it's not set. In this case I guess it works just like if the time period was set to 24x7.

For services there is a check at naemon/configuration.c:1505 but for hosts there is only a check at naemon/configuration.c:1585 which only checks whether the timeperiod is valid if any is given.

This behavior should either be changed or documented. There might be similar problems for other attributes but check_period was the only one I looked at.

@ageric
Copy link
Contributor

ageric commented Aug 7, 2014

On 2014-08-04 17:39, Julian wrote:

The docs on host
objects

list check_period as a required attribute but Naemon starts fine
(even without warnings) if it's not set. In this case I guess it
works just like if the time period was set to 24x7.

For services there is a check at
naemon/configuration.c:1505
but for hosts there is only a check at
naemon/configuration.c:1585
which only checks whether the timeperiod is valid if any is given.

This behavior should either be changed or documented. There might be
similar problems for other attributes but check_period was the only
one I looked at.

check_period isn't required, and if one isn't supplied 24x7 will be
used. I'll make a note to amend the docs.

/Andreas

@catharsis
Copy link
Contributor

I've opened naemon/naemon.github.io#59 to track this documentation update instead. Thanks for reporting it @julianbrost, and sorry for the late feedback!

op5-ci-user pushed a commit that referenced this issue Apr 4, 2018
…-doesnt-compile-with-gcc7 to master

* commit 'b73ef00e50ca33e6c63116bcc7d0ed5beaba9675':
  Check snprintf for encoding errors and truncation
  Mark intentional fallthroughs in switch statements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants