Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File builder freezes upon encountering a module with a special character #117

Closed
antlersss opened this issue Apr 18, 2023 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@antlersss
Copy link

What I expected to happen
I expected the builder to either throw an exception stating that my module name was invalid, or that it would accept the module outright.

What happened instead
The builder gets stuck, saying it's still building. The only way to stop it is to exit the program.

How do I reproduce this?
Reliable steps that should produce this issue:

  1. Create a package with a special character (in my case, it was -)
  2. Add requires([package name]) somewhere in your script.
  3. Attempt to build.

Screenshots and Project zip file
N/A

Additional info
It's alright if the program can't accept special characters, just a simple check that any provided modules contained them and alerting the user about it would be helpful.

@antlersss antlersss added the bug Something isn't working label Apr 18, 2023
@antlersss
Copy link
Author

Resolved in merge request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant