Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/Update frontend packages #158

Open
yarkhinephyo opened this issue Mar 4, 2022 · 1 comment
Open

Chore/Update frontend packages #158

yarkhinephyo opened this issue Mar 4, 2022 · 1 comment
Assignees
@siman4457

Comments

@yarkhinephyo
Copy link
Member

yarkhinephyo commented Mar 4, 2022 •
edited
Loading

Issue

Frontend packages are outdated in RouteMaker/ionic_user_interface/package.json.

Suggestion

Configure simple tests with high coverage.
Update packages.
Modify .husky/pre-commit to ensure tests run before committing.
Add .github/workflows to ensure tests pass in CI.

Ensure duplicate packages in RouteMaker/package.json are updated as well.
(The package.json in root directory is for pre-commit + lint-staged + eslint to work with both ionic_user_interface and lambda_backend, not sure if there is a better way other than having duplicate packages)
@yarkhinephyo yarkhinephyo mentioned this issue Mar 4, 2022
Open
@siman4457
Copy link

Picking this up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@siman4457 siman4457

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yarkhinephyo @siman4457