Added build time args for more flexibility

Author: nanic

.gitignore

@@ -0,0 +1 @@
+.DS_Store

Dockerfile

@@ -1,11 +1,15 @@
 FROM azul/zulu-openjdk-alpine:11
 
-MAINTAINER Naren <[email protected]>
+LABEL maintainer="Naren Ravilla"
+
+ARG CMAK_VERSION="3.0.0.5"
+ARG ZK_HOSTS="zookeeper:2181"
+ARG CMAK_CONFIGFILE="conf/application.conf"
 
 ENV JAVA_HOME=/usr/lib/jvm/java-11-openjdk/ \
-	ZK_HOSTS=zookeeper:2181 \
-	CMAK_VERSION=3.0.0.5\
-	CMAK_CONFIGFILE="conf/application.conf"
+	ZK_HOSTS=$ZK_HOSTS \
+	CMAK_VERSION=$CMAK_VERSION \
+	CMAK_CONFIGFILE=$CMAK_CONFIGFILE
 
 WORKDIR /opt
 

README.md

@@ -2,6 +2,15 @@
 
 CMAK is a tool for managing Kafka cluster(s). This repository creates a docker image for running CMAK as a container. The actual CMAK repository is located [here](https://github.com/yahoo/CMAK).
 
+## How to build the image:
+
+```sh
+$ docker build --build-arg CMAK_VERSION="3.0.0.5" -t <image-tag> .
+```
+
+You can also pass in `ZK_HOSTS` & `CMAK_CONFIGFILE` as build time arguments.
+
+
 > I have also added docker-compose and kubernetes deployment files for helping to set up a simple local kafka setup along with CMAK.
 
 * For docker-compose
@@ -23,4 +32,4 @@ $ kubectl apply -f cmak.yaml
 
 hit `localhost:30090` in browser of your choice for accessing CMAK.
 
-**Note: We are using different port in case of kubernetes setup because of Kubernetes Service(NodePort) setup in k8s cluster.**
+**Note: We are using different port in case of kubernetes setup because of Kubernetes Service(NodePort) setup in k8s cluster.**

docker-compose/docker-compose.yml

@@ -19,8 +19,13 @@ services:
       KAFKA_LISTENER_SECURITY_PROTOCOL_MAP: PLAINTEXT:PLAINTEXT,PLAINTEXT_HOST:PLAINTEXT
       KAFKA_INTER_BROKER_LISTENER_NAME: PLAINTEXT
       KAFKA_OFFSETS_TOPIC_REPLICATION_FACTOR: 1
+      KAFKA_JMX_PORT: 9999
   kafka-manager:
-    image: nanic/cmak:latest
+    build:
+      dockerfile: Dockerfile
+      context: ../.
+      args:
+        CMAK_VERSION: "3.0.0.5"
     ports:
       - "9000:9000"
     depends_on: