Skip to content

Commit 1fb23f1

Browse files
authored
Merge pull request avocado-framework#3801 from nanliu-r/update_to_python3_format
virtio_console_guest:update code format to keep compatibility
2 parents 065fa0a + 2773289 commit 1fb23f1

File tree

1 file changed

+35
-18
lines changed

1 file changed

+35
-18
lines changed

virttest/shared/scripts/virtio_console_guest.py

Lines changed: 35 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,32 @@
2121
import signal
2222
import time
2323
import platform
24-
try:
25-
import six
26-
except ImportError:
27-
import subprocess
28-
subprocess.check_call([sys.executable, "-m", "pip", "install", "six"])
29-
from six.moves import xrange
30-
from six.moves import input
3124
from distutils.version import LooseVersion # pylint: disable=W0611,E0611
3225

26+
# For Python 2 and 3 compatibility
27+
# xrange
28+
try:
29+
range = xrange
30+
except NameError:
31+
pass
32+
# raw_input
33+
try:
34+
input = raw_input
35+
except NameError:
36+
pass
37+
# iteritems, itervalues
38+
if sys.version_info[0] == 3:
39+
def itervalues(d, **kw):
40+
return iter(d.values(**kw))
41+
42+
def iteritems(d, **kw):
43+
return iter(d.items(**kw))
44+
else:
45+
def itervalues(d, **kw):
46+
return d.itervalues(**kw)
47+
48+
def iteritems(d, **kw):
49+
return d.iteritems(**kw)
3350

3451
if os.name == "posix": # Linux
3552
os_linux = True
@@ -276,7 +293,7 @@ def _get_port_status(self, in_files=None):
276293
line_list.append(line)
277294
try:
278295
for line in line_list:
279-
m = re.match("(\S+): (\S+)", line)
296+
m = re.match(r"(\S+): (\S+)", line)
280297
port[m.group(1)] = m.group(2)
281298

282299
if port['is_console'] == "yes":
@@ -428,7 +445,7 @@ def _reconnect_none_mode(self):
428445
# when bz796048 is resolved.
429446
while not self.exit_thread.isSet():
430447
data = b""
431-
for i in xrange(len(self.in_files)):
448+
for i in range(len(self.in_files)):
432449
if self.exit_thread.isSet():
433450
break
434451
desc = self.in_files[i]
@@ -447,11 +464,11 @@ def _reconnect_none_mode(self):
447464
sys.stdout.write("Missing device, readerr %s\n"
448465
% inst)
449466
_desc = desc
450-
for item in six.iteritems(virt.files):
467+
for item in iteritems(virt.files):
451468
if item[1] == desc:
452469
path = item[0]
453470
break
454-
for item in six.iteritems(virt.ports):
471+
for item in iteritems(virt.ports):
455472
if item[1]['path'] == path:
456473
name = item[0]
457474
break
@@ -466,7 +483,7 @@ def _reconnect_none_mode(self):
466483
pass
467484
self.in_files[self.in_files.index(_desc)] = desc
468485
if data != b"":
469-
for i in xrange(len(self.out_files)):
486+
for i in range(len(self.out_files)):
470487
if self.exit_thread.isSet():
471488
break
472489
desc = self.out_files[i]
@@ -492,11 +509,11 @@ def _reconnect_none_mode(self):
492509
sys.stdout.write("Missing device, writeerr"
493510
" %s\n" % inst)
494511
_desc = desc
495-
for item in six.iteritems(virt.files):
512+
for item in iteritems(virt.files):
496513
if item[1] == desc:
497514
path = item[0]
498515
break
499-
for item in six.iteritems(virt.ports):
516+
for item in iteritems(virt.ports):
500517
if item[1]['path'] == path:
501518
name = item[0]
502519
break
@@ -796,7 +813,7 @@ def open(self, in_file, attempts=1):
796813
:return: Array of descriptors.
797814
"""
798815
opened = False
799-
for i in xrange(attempts):
816+
for i in range(attempts):
800817
try:
801818
name = self.ports[in_file]["path"]
802819
self.files[name] = os.open(name, os.O_RDWR)
@@ -848,7 +865,7 @@ def exit_threads(self):
848865
self.exit_thread.clear()
849866

850867
del self.threads[:]
851-
for desc in six.itervalues(self.files):
868+
for desc in itervalues(self.files):
852869
os.close(desc)
853870
self.files.clear()
854871
print("PASS: All threads finished")
@@ -986,7 +1003,7 @@ def init(self, in_files):
9861003

9871004
# Check if all ports really exists
9881005
remove = []
989-
for item in six.iteritems(self.ports):
1006+
for item in iteritems(self.ports):
9901007
port = item[1]
9911008
try:
9921009
hFile = win32file.CreateFile(port['path'], 0, 0, None,
@@ -1095,7 +1112,7 @@ def exit_threads(self):
10951112
self.exit_thread.clear()
10961113

10971114
del self.threads[:]
1098-
for desc in six.itervalues(self.files):
1115+
for desc in itervalues(self.files):
10991116
win32file.CloseHandle(desc)
11001117
self.files.clear()
11011118
print("PASS: All threads finished")

0 commit comments

Comments
 (0)