Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WS and WSS should permit empty path #95

Open
gdamore opened this issue Jun 24, 2018 · 2 comments
Open

WS and WSS should permit empty path #95

gdamore opened this issue Jun 24, 2018 · 2 comments

Comments

@gdamore
Copy link
Contributor

gdamore commented Jun 24, 2018

An empty websocket path is the same same as "/" per the HTTP RFC. We should canonicalize the URL as specified.
@gdamore gdamore transferred this issue from nanomsg/mangos-v1 Jun 28, 2019
@gdamore
Copy link
Contributor Author

gdamore commented Sep 22, 2019

It looks like this is done properly in the listener side already.

@gdamore
Copy link
Contributor Author

gdamore commented Sep 22, 2019

Actually because of the way the HTTP mux works, we might not want to do that. In particular, a path ending in "/" winds up getting muxed to all paths, whereas "" would only match the implied "/".

Some investigation may be warranted here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gdamore