Skip to content

Port to Plasma 6 #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

RiskoZoSlovenska
Copy link

@RiskoZoSlovenska RiskoZoSlovenska commented Jan 31, 2025

This PR updates the plugin to Plasma 6 and cleans up the CMake and README files a bit.

Notable side effects:

  • Support for Plasma 5 has been removed. As there are people still using Plasma 5, I recommend merging this PR into a new branch instead of master (or archiving the current master into a new branch).
  • The plugin ID, and thus the configuration group name, has changed from Translator to krunner_translator; users who upgraded from Plasma 5 will need to reconfigure the plugin.
  • The installation instructions have been updated; the README lists the commands to run and the installation/uninstallation scripts have been removed. This is a somewhat opinionated change, as I believe the scripts did not offer much value and I'd prefer users read the commands they run on their machine.
  • The uninstallation scripts now attempt to install the required build and runtime dependencies (including translate-shell) via apt or dnf.
  • The README no longer lists dependencies for OpenSUSE.

Closes #30.

* Update to Plasma 6 APIs
* Fix some Plasma 6 errors/warnings
* Update CMakeLists.txt and README to get the correct dependencies
* Fix README reporting incorrect defaults
* Update build instructions
* Remove unnecessary files
* Possibly fix some configuration bugs
* Misc. formatting fixes
@thegrasshopper104
Copy link

thegrasshopper104 commented Jan 31, 2025

I tried simply installing your version from the store but it fails:

/home/aronkvh/.local/share/krunner-sources/krunner-translator-1.5.0/install.sh
/home/aronkvh/.local/share/krunner-sources/krunner-translator-1.5.0/install.sh: sor: 8: kf5-config: not found
/home/aronkvh/.local/share/krunner-sources/krunner-translator-1.5.0/install.sh: sor: 8: kf5-config:  not found
/home/aronkvh/.local/share/krunner-sources/krunner-translator-1.5.0/install.sh: sor: 8: cmake:  not found

Building from your fork worked luckily, and (except for TTS) it works for me.
Thanks for the port :)

@RiskoZoSlovenska
Copy link
Author

Hi @thegrasshopper104, I haven't published my fork to the KDE store; you tried to install the original version. I forgot to remove the store link from my repo and will do so now.

The plugin uses translate-shell for TTS, which in turn needs mpv, mplayer or mpg123. Make sure you have one of those installed. Thanks for your feedback!

They now also attempt to install all the necessary dependencies
They might be helpful for users installing the plugin from the KDE store
Who thought that trailing whitespace being significant was a good idea?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KDE Plasma 6 Support
2 participants