Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LBIdentity #4

Open
1 of 3 tasks
addisonhardy opened this issue Sep 22, 2022 · 2 comments · Fixed by #7
Open
1 of 3 tasks

LBIdentity #4

addisonhardy opened this issue Sep 22, 2022 · 2 comments · Fixed by #7
Labels
enhancement New feature or request

Comments

@addisonhardy
Copy link
Contributor

addisonhardy commented Sep 22, 2022 •
edited by Scotchester
Loading

  • Add a new LBIdentity class (Add LBIdentity class for integrating with identity plugins #7)
  • Update bridge API user create view:
    • Use new LBIdentity.get method
    • Use normal Django model create method to create the user object
  • In WCP:
    • Drop custom JPLPersonnel.user method and replace with post_save signal handler
    • In post_save handler method, call LBIdentity.get(identifier) to hydrate user attrs
@addisonhardy addisonhardy added the enhancement New feature or request label Sep 22, 2022
@Scotchester Scotchester linked a pull request Oct 24, 2022 that will close this issue
Add LBIdentity class for integrating with identity plugins #7
Merged
@Scotchester
Copy link
Member

Done in #7

@Scotchester
Copy link
Member

Oops, actually only the first part is done.

@Scotchester Scotchester reopened this Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add LBIdentity class for integrating with identity plugins nasa-jpl/django-launchbox
2 participants
@Scotchester @addisonhardy