[#451] Error checking

Author: Donnie-Ice

include/crypto_error.h

@@ -154,8 +154,9 @@
 #define CRYPTO_LIB_ERR_TM_SECONDARY_HDR_SIZE                                (-80)
 #define CRYPTO_LIB_ERR_TM_SECONDARY_HDR_VN                                  (-81)
 #define CRYPTO_LIB_ERR_TC_FRAME_LENGTH_MISMATCH                             (-82)
+#define CRYPTO_LIB_ERR_SHPLF_LEN_LESS_THAN_MIN_PAD_SIZE                     (-83)
 
-#define CRYPTO_CORE_ERROR_CODES_MAX -82
+#define CRYPTO_CORE_ERROR_CODES_MAX -83
 
 // Define codes for returning MDB Strings, and determining error based on strings
 #define CAM_ERROR_CODES     600

src/core/crypto_error.c

@@ -103,7 +103,8 @@ char *crypto_enum_errlist_core[] = {(char *)"CRYPTO_LIB_SUCCESS",
                                     (char *)"CRYPTO_LIB_ERR_INVALID_FHECF",
                                     (char *)"CRYPTO_LIB_ERR_TM_SECONDARY_HDR_SIZE",
                                     (char *)"CRYPTO_LIB_ERR_TM_SECONDARY_HDR_VN",
-                                    (char *)"CRYPTO_LIB_ERR_TC_FRAME_LENGTH_MISMATCH"};
+                                    (char *)"CRYPTO_LIB_ERR_TC_FRAME_LENGTH_MISMATCH",
+                                    (char *)"CRYPTO_LIB_ERR_SHPLF_LEN_LESS_THAN_MIN_PAD_SIZE"};
 
 char *crypto_enum_errlist_config[] = {
     (char *)"CRYPTO_CONFIGURATION_NOT_COMPLETE",

src/core/crypto_tc.c

@@ -1034,6 +1034,12 @@ int32_t Crypto_TC_ApplySecurity_Cam(const uint8_t *p_in_frame, const uint16_t in
             break;
     }
 #endif
+    if ((encryption_cipher == CRYPTO_CIPHER_AES256_CBC || encryption_cipher == CRYPTO_CIPHER_AES256_CBC_MAC) && sa_ptr->shplf_len == 0)
+    {
+        status = CRYPTO_LIB_ERR_SHPLF_LEN_LESS_THAN_MIN_PAD_SIZE;
+        mc_if->mc_log(status);
+        return status;
+    }
 
     // Determine if segment header exists and FECF exists
     uint8_t segment_hdr_len = TC_SEGMENT_HDR_SIZE;