Skip to content

🐛 [BUG] - Fix Key Verification IV values #446

Open
@dccutrig

Description

@dccutrig

Description

Currently keyv just increments a counter, research this a little further and likely need to use the active SA IV (either SA 0 or max for EPs)

Image

I was looking at Crypto_Increment, it only does an increment of +1 on each call. In this example we have a + x + 1... which I think is just so they are all unique. If we use the existing crypto_increment, without the + x, we'd either have to use a for loop X times to increment, or re-write the UTs using it.

Are there any issues with the proposed change along the lines of:

for ( int j=0; j<x; j++ )
{
Crypto_Increment(sdls_ep_keyv_reply.blk[x].iv, SDLS_IV_LEN);
}

I'm unclear on what the second increment could / should be for the line:

sdls_ep_reply[pdu_data_idx - 1] = sdls_ep_reply[pdu_data_idx - 1] + x + 1;

REVIEW this and update.

Branch Name

No response

Reproduction steps

Not blank

Screenshots

![DESCRIPTION](LINK.png)

Logs

OS

Linux

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions