-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Description
Summary
On a user triggered bounds change, via time conductor inputs, telemetry collections will clear all data and re-request historical data. Subscription continues and is not reset. Some subscription providers not only provide new messages, but also provide latest available data on initializing subscription. This edge case will drop that latest available data that is received on initial subscription.
Solution is to simply call _initiateSubscriptionTelemetry in _reset, as is done on telemetry collection load.
Collections could also be more data aware per #5143.
In fact, as i am looking at the code there is a comment in the jsdoc for _reset, "@todo handle subscriptions more granularly".
Expected vs Current Behavior
No data should be lost on bounds change
Steps to Reproduce
Caveat - your telemetry provider for objects used must support latest available data via subscription
- Navigate to a LAD table object, with composition providing telemetry
- Ensure the view displays some telemetry data
- Switch to Fixed time
- put the time conductor bounds into the future, so that there should be no telemetry yet
- observe LAD view displays no telemetry
- refresh the page
- observe LAD view displays latest available telemetry (despite the future time window)
Environment
- Open MCT Version:
- Deployment Type:
- OS:
- Browser:
Impact Check List
- Data loss or misrepresented data?
- Regression? Did this used to work or has it always been broken?
- Is there a workaround available?
- Does this impact a critical component?
- Is this just a visual bug with no functional impact?
- Does this block the execution of e2e tests?
- Does this have an impact on Performance?