Skip to content

Remove addrlen switch duplication #864

New issue
New issue
Open
#1388
Open
Remove addrlen switch duplication#864
#1388
Labels
CFS-38enhancement
@skliper

Description

@skliper
skliper
opened on Mar 10, 2021

Is your feature request related to a problem? Please describe.
Switch to get addrlen repeated multiple times:

osal/src/os/portable/os-impl-bsd-sockets.c

Lines 188 to 201 in ead5723

switch (sa->sa_family)
{
case AF_INET:
addrlen = sizeof(struct sockaddr_in);
break;
#ifdef OS_NETWORK_SUPPORTS_IPV6
case AF_INET6:
addrlen = sizeof(struct sockaddr_in6);
break;
#endif
default:
addrlen = 0;
break;
}

osal/src/os/portable/os-impl-bsd-sockets.c

Lines 248 to 262 in ead5723

sa = (const struct sockaddr *)&Addr->AddrData;
switch (sa->sa_family)
{
case AF_INET:
slen = sizeof(struct sockaddr_in);
break;
#ifdef OS_NETWORK_SUPPORTS_IPV6
case AF_INET6:
slen = sizeof(struct sockaddr_in6);
break;
#endif
default:
slen = 0;
break;
}

osal/src/os/portable/os-impl-bsd-sockets.c

Lines 484 to 498 in ead5723

sa = (const struct sockaddr *)&RemoteAddr->AddrData;
switch (sa->sa_family)
{
case AF_INET:
addrlen = sizeof(struct sockaddr_in);
break;
#ifdef OS_NETWORK_SUPPORTS_IPV6
case AF_INET6:
addrlen = sizeof(struct sockaddr_in6);
break;
#endif
default:
addrlen = 0;
break;
}

osal/src/os/portable/os-impl-bsd-sockets.c

Lines 545 to 561 in ead5723

switch (Domain)
{
case OS_SocketDomain_INET:
sa_family = AF_INET;
addrlen = sizeof(struct sockaddr_in);
break;
#ifdef OS_NETWORK_SUPPORTS_IPV6
case OS_SocketDomain_INET6:
sa_family = AF_INET6;
addrlen = sizeof(struct sockaddr_in6);
break;
#endif
default:
sa_family = 0;
addrlen = 0;
break;
}

Describe the solution you'd like
Calculate once and store or implement once and inline

Describe alternatives you've considered
Leave as-is (future work)

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC, OSAL code review

Metadata

Metadata

Assignees

No one assigned

    Labels

    CFS-38enhancement

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions