Skip to content

Commit 958a4ba

Browse files
committed
fix(ci)!: disable lua 5.1 and luajit on master, drop 0.15.2 support
Now that nightly builds of Zig 0.16 have sufficiently diverged from 0.15.2, it's time to drop CI support on the main branch of ziglua in order to continue merging PRs. Unfortunately, the latest versions of `zig translate-c` appear to be unable to deal with the `LUA_QL` macro present in Lua 5.1 and LuaJIT. I've opened an issue, which is linked below. Once that issue is resolved, these tests should be reenabled. https://codeberg.org/ziglang/translate-c/issues/282
1 parent 5b61a77 commit 958a4ba

File tree

2 files changed

+32
-28
lines changed

2 files changed

+32
-28
lines changed

.github/workflows/tests.yml

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -28,24 +28,24 @@ jobs:
2828
run: make test_zig_nightly
2929

3030
#------ zig-0.15 ------
31-
test_zig_015:
32-
strategy:
33-
matrix:
34-
os: [ubuntu-latest, macos-latest, windows-latest, ubuntu-24.04-arm]
31+
#test_zig_015:
32+
# strategy:
33+
# matrix:
34+
# os: [ubuntu-latest, macos-latest, windows-latest, ubuntu-24.04-arm]
3535

36-
runs-on: ${{matrix.os}}
36+
# runs-on: ${{matrix.os}}
3737

38-
steps:
39-
- name: Clone Ziglua
40-
uses: actions/checkout@v3
38+
# steps:
39+
# - name: Clone Ziglua
40+
# uses: actions/checkout@v3
4141

42-
- name: Setup Zig
43-
uses: mlugg/setup-zig@v2
44-
with:
45-
version: "0.15.2"
42+
# - name: Setup Zig
43+
# uses: mlugg/setup-zig@v2
44+
# with:
45+
# version: "0.15.2"
4646

47-
- name: Run tests
48-
run: make test_zig_stable
47+
# - name: Run tests
48+
# run: make test_zig_stable
4949

5050
#------ cross compilation ------
5151
test_cross:

makefile

Lines changed: 18 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
.PHONY: test docs
22

33
test_zig_nightly:
4-
zig build test --summary failures -Dlang=lua51
4+
# FIXME: reenable after resolution of https://codeberg.org/ziglang/translate-c/issues/282
5+
# zig build test --summary failures -Dlang=lua51
56
zig build test --summary failures -Dlang=lua52
67
zig build test --summary failures -Dlang=lua53
78
zig build test --summary failures -Dlang=lua54
@@ -11,7 +12,8 @@ test_zig_nightly:
1112
zig build install-example-zig-function
1213
zig build -Dlang=luau install-example-luau-bytecode
1314

14-
zig build -Dlang=luajit
15+
# FIXME: reenable after resolution of https://codeberg.org/ziglang/translate-c/issues/282
16+
# zig build -Dlang=luajit
1517

1618
# A subset of tests that are expected to work also on stable builds of zig
1719
test_zig_stable:
@@ -25,18 +27,20 @@ test_zig_stable:
2527
zig build install-example-zig-function
2628
zig build -Dlang=luau install-example-luau-bytecode
2729

28-
test_cross:
29-
zig build -Dlang=lua51 -Dtarget=aarch64-linux
30-
zig build -Dlang=lua51 -Dtarget=aarch64-linux-gnu
31-
zig build -Dlang=luajit -Dtarget=aarch64-linux
32-
zig build -Dlang=luajit -Dtarget=aarch64-linux-gnu
33-
34-
zig build -Dlang=lua51 -Dtarget=x86_64-linux
35-
zig build -Dlang=lua51 -Dtarget=x86_64-linux-gnu
36-
zig build -Dlang=luajit -Dtarget=x86_64-linux
37-
zig build -Dlang=luajit -Dtarget=x86_64-linux-gnu
38-
39-
zig build -Dlang=luajit -Dtarget=aarch64-macos
30+
# TODO: audit this; is it expected that cross-compilation should be an issue?
31+
# FIXME: reenable after resolution of https://codeberg.org/ziglang/translate-c/issues/282
32+
# test_cross:
33+
# zig build -Dlang=lua51 -Dtarget=aarch64-linux
34+
# zig build -Dlang=lua51 -Dtarget=aarch64-linux-gnu
35+
# zig build -Dlang=luajit -Dtarget=aarch64-linux
36+
# zig build -Dlang=luajit -Dtarget=aarch64-linux-gnu
37+
#
38+
# zig build -Dlang=lua51 -Dtarget=x86_64-linux
39+
# zig build -Dlang=lua51 -Dtarget=x86_64-linux-gnu
40+
# zig build -Dlang=luajit -Dtarget=x86_64-linux
41+
# zig build -Dlang=luajit -Dtarget=x86_64-linux-gnu
42+
#
43+
# zig build -Dlang=luajit -Dtarget=aarch64-macos
4044

4145
docs:
4246
zig build docs

0 commit comments

Comments
 (0)