Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templating broken by errant unset statement #307

Open
sosherof opened this issue Mar 13, 2024 · 1 comment
Open

Templating broken by errant unset statement #307

sosherof opened this issue Mar 13, 2024 · 1 comment

Comments

@sosherof
Copy link
Contributor

At the end of Requests->send() is an unset statement that kills the curl handle property ($this->_ch). This throws a warning in PHP 8.x. See PR for fix.

@sosherof
Copy link
Contributor Author

sosherof commented May 1, 2024

I see now that this is related to issue #227 (PR #229 ). I think the correct action is to set the _ch object to null so it'll be GC'd and can be reset during the next send operations. Using unset removes the property from the Request object instance and PHP 8 doesn't allow dynamic property creation so the subsequent call to _curlPrep() at the top of send() throws an error.

See PR #306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant