Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting "Include All Responses" is missing #792

Closed
Radagasd opened this issue Feb 18, 2025 · 1 comment · Fixed by #793
Closed

Setting "Include All Responses" is missing #792

Radagasd opened this issue Feb 18, 2025 · 1 comment · Fixed by #793
Assignees
@nathanhoad
Labels
bug Something isn't working

Comments

@Radagasd
Copy link

Describe the bug
The documentation on settings notes that there is a Include All Responses option. However, looking in Godot it does not appear to be there. Either something is wrong, or the documentation needs to be updated.

By the way, just getting started with the addon but it looks lovely so far.

Affected version

  • Dialogue Manager version: 3.3.2
  • Godot version: 4.3

To Reproduce
Steps to reproduce the behavior:

  1. Open the runtime settings for Dialogue Manager
  2. See that Include All Responses is not an option

Expected behavior
Either there should be an Include All Responses option in the settings, or the documentation needs to be updated.

Screenshots
Screenshot of the runtime settings, where Include All Responses is absent.

Image
@Radagasd Radagasd added the bug Something isn't working label Feb 18, 2025
@Fireye04
Copy link
Contributor

Looks like support for the Include All Responses setting was removed in the 3.0 update (https://github.com/nathanhoad/godot_dialogue_manager/releases/tag/v3.0.0), and was instead moved to the DialogueResponsesMenu node as an exported variable, meaning that this can be set from the balloon scene. For example, if using the example balloon:

/addons/dialogue_manager/example_balloon/example_balloon.tscn
Image

(in the inspector) Toggle on/off hide failed responses (negated boolean of include all responses)
Image

I'll go ahead and open up a PR to fix the docs; thanks for the report!

@Fireye04 Fireye04 mentioned this issue Feb 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathanhoad nathanhoad

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Include All Responses from docs Fireye04/godot_dialogue_manager
3 participants
@nathanhoad @Radagasd @Fireye04