From e20fd762b9d3460b16318e5ae0785d7eb5ca8336 Mon Sep 17 00:00:00 2001 From: Antony Male Date: Sat, 1 Feb 2025 23:30:10 +0000 Subject: [PATCH] Remove Battery SoH from the Kuara H3 Fixes: #756 --- .../foxess_modbus/entities/entity_descriptions.py | 2 +- ..._entity_descriptions_for_model[Inv.KUARA_H3].json | 12 ------------ 2 files changed, 1 insertion(+), 13 deletions(-) diff --git a/custom_components/foxess_modbus/entities/entity_descriptions.py b/custom_components/foxess_modbus/entities/entity_descriptions.py index 078abf3c..66576f57 100644 --- a/custom_components/foxess_modbus/entities/entity_descriptions.py +++ b/custom_components/foxess_modbus/entities/entity_descriptions.py @@ -2119,7 +2119,7 @@ def _inner( battery_soh=[ ModbusAddressesSpec(input=[11104], models=Inv.KH_PRE119), ModbusAddressesSpec(holding=[37624], models=Inv.H1_G2_SET | Inv.KH_PRE133 | Inv.KH_133), - ModbusAddressesSpec(holding=[31090], models=Inv.H3_SET), + ModbusAddressesSpec(holding=[31090], models=Inv.H3_SET & ~Inv.KUARA_H3), ], battery_temp=[ ModbusAddressesSpec(input=[11038], models=Inv.H1_G1 | Inv.KH_PRE119), diff --git a/tests/__snapshots__/test_entity_descriptions/test_entity_descriptions_for_model[Inv.KUARA_H3].json b/tests/__snapshots__/test_entity_descriptions/test_entity_descriptions_for_model[Inv.KUARA_H3].json index b437061e..9510d8e6 100644 --- a/tests/__snapshots__/test_entity_descriptions/test_entity_descriptions_for_model[Inv.KUARA_H3].json +++ b/tests/__snapshots__/test_entity_descriptions/test_entity_descriptions_for_model[Inv.KUARA_H3].json @@ -109,18 +109,6 @@ "signed": false, "type": "sensor" }, - { - "addresses": { - "holding": [ - 31090 - ] - }, - "key": "battery_soh", - "name": "Battery SoH", - "scale": null, - "signed": false, - "type": "sensor" - }, { "addresses": { "holding": [